#57: holdingpattern should not be a required key ------------------------+--------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: new Priority: minor | Milestone: Component: SimFactory | Version: Keywords: | ------------------------+--------------------------------------------------- Currently, the key "holdingpattern" must be provided in all machine definitions. This is not necessary for machines on which you don't have a queuing system, for example a laptop. The key should be optional.
#57: holdingpattern should not be a required key -------------------------+-------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: new Priority: minor | Milestone: Component: SimFactory | Version: Resolution: | Keywords: -------------------------+--------------------------------------------------
Comment (by eschnett):
This applies not only to holding pattern, but to all other keys in the "simulation" section as well.
On the other hand, checking for the presence of keys only when they are required complicates debugging, as e.g. the consistency of keys necessary for mpirun would only be checked once the simulation starts after waiting in the queue. Many keys also have default values, and missing keys are then difficult to detect.
What we should have instead is a way to specify whether a machine supports building, or running, or archiving, and these keys should then only be required if that is the case. If the machine does not support an activity, an error should be emitted early.
commits@lists.einsteintoolkit.org
-
Einstein Toolkit