#123: Run a syntax checker in a pre-commit hook
------------------------+---------------------------------------------------
Reporter: eschnett | Owner: mthomas
Type: defect | Status: new
Priority: major | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
I am getting annoyed by the frequent syntax errors in SimFactory that used
to be caught by Perl and are now not caught by Python. It would be ideal
if syntax checking could be built into SimFactory, so that it executes
automatically during startup if that isn't too slow.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/123>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#124: Implement a testing mechanism for simfactory
-------------------------+--------------------------------------------------
Reporter: hinder | Owner: mthomas
Type: enhancement | Status: new
Priority: major | Milestone:
Component: SimFactory | Version:
Keywords: |
-------------------------+--------------------------------------------------
Currently there is no easy way to check that a change to simfactory hasn't
broken critical functionality. A system could be introduced to run
through each command and check that it does the right thing. It won't be
possible to check every single combination of possible options, but the
most commonly used options should be tested.
A first attempt could involve testing that the commands work locally on
the current machine. This would involve submitting jobs and testing that
they have the expected behaviour. On busy machines, this means that the
tests could potentially take a long time to complete.
Remote submission could be tested by running these tests from a central
location (e.g. the developer's workstation or laptop).
We could also include a python correctness checking step in these tests
(e.g. using pychecker or pylint).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/124>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#113: Simfactory should be able to run the Cactus testsuites
-------------------------+--------------------------------------------------
Reporter: knarf | Owner: mthomas
Type: enhancement | Status: new
Priority: critical | Milestone: ET_2011_06
Component: SimFactory | Version:
Keywords: |
-------------------------+--------------------------------------------------
... in the python version, before the next ET release. The scripts at
http://einsteintoolkit.org/release-info/ might help with implementing
that.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/113>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#122: Code documentation
-------------------------+--------------------------------------------------
Reporter: hinder | Owner: mthomas
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
-------------------------+--------------------------------------------------
In order to help new developers understand the code, the following would
be useful:
* Provide some sort of high-level overview of the internal components of
simfactory. This could be in the form of a class diagram with annotations
indicating what each class does, and its relationship to the other classes
(inheritence/object membership etc). There must be tools for doing this
for python and generating doxygen-type output.
* Within the source code, provide at least a one-line comment for each
function indicating what it does.
* Ensure that the readmes etc in the repository are up-to-date, or at
least remove any out-of-date information.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/122>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#127: Restarts should have hard link to executable
------------------------+---------------------------------------------------
Reporter: eschnett | Owner: mthomas
Type: defect | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
Restarts should contain a copy of the executable, so that they are self-
contained. This "copy" should be implemented via a hard link if possible
(to save space).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/127>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#125: Old SImFactory web page should have a link to the new one
-------------------------+--------------------------------------------------
Reporter: hinder | Owner: mthomas
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
-------------------------+--------------------------------------------------
The web page at http://www.cct.lsu.edu/~eschnett/SimFactory/ should have a
link to the simfactory.org website.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/125>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#77: Strange error message
------------------------+---------------------------------------------------
Reporter: eschnett | Owner: mthomas
Type: defect | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
I received the following error message from SimFactory:
$ ./simfactory/sim sync mars
Traceback (most recent call last):
File "./simfactory/sim", line 158, in <module>
SimEnvironment.initApp(usageString=buildUsageString(),
optionGroups=optionGroups)
File "/Users/eschnett/EinsteinToolkit-hg/simfactory/lib/simenv.py", line
71, in initApp
self.LoadConfigurationDatabase()
File "/Users/eschnett/EinsteinToolkit-hg/simfactory/lib/simenv.py", line
131, in LoadConfigurationDatabase
self.ConfigurationDatabase.Load()
File "/Users/eschnett/EinsteinToolkit-hg/simfactory/lib/simdb.py", line
78, in Load
self.CheckSyntax()
File "/Users/eschnett/EinsteinToolkit-hg/simfactory/lib/simdb.py", line
109, in CheckSyntax
syntaxChecker.SyntaxCheck()
File "/Users/eschnett/EinsteinToolkit-hg/simfactory/lib/pyini.py", line
357, in SyntaxCheck
self.SyntaxError("required key %s in section %s is missing" % (skey,
ini_section))
File "/Users/eschnett/EinsteinToolkit-hg/simfactory/lib/pyini.py", line
418, in SyntaxError
dprint("Syntax error: %s" % (error))
File "/Users/eschnett/EinsteinToolkit-hg/simfactory/lib/libutil.py",
line 22, in dprint
lib = env.SimLib
AttributeError: SimEnvironment instance has no attribute 'SimLib'
I assume I have an error in my local mdb for a machine called "Mars";
however, I don't see what key is missing or what error I have.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/77>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#100: ExternalLibraries/HDF5/HDF5.sh fails to catch a missing library file in
user implementation
------------------------------------+---------------------------------------
Reporter: bmundim | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Other | Version:
Keywords: ExternalLibraries HDF5 |
------------------------------------+---------------------------------------
When the user sets for example both
HDF5=yes
HDF5_DIR=/usr
the script HDF5.sh fails to assert if all library files are currently
present in
the user HDF5 implementation, what leads later on to a linking error,
halting then
the executable building process. Some library files are missing in the
HDF5
version shipped by the Ubuntu distro, for example:
libhdf5_hl_cpp.a
Shouldn't the script output an warning message, and allow linking without
this
option, since this is not a core library file?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/100>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#101: Update ExternalLibraries/OpenSSL to version openssl-1.0.0b
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
----------------------+-----------------------------------------------------
... because this version has several security problems corrected.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/101>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#106: Place executed commands into LOG file
------------------------+---------------------------------------------------
Reporter: eschnett | Owner: mthomas
Type: defect | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
SimFactory should put the exact commands that are executed on behalf of a
simulation into the LOG file. This concerns in particular those commands
that change the state of a simulation (qsub, qdel); purely inquiring
commands should not be logged (qstat).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/106>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit