#2819: SetMask_SphericalSurface uses LoopControl's LC_LOOP but does not require LoopControl
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Changes (by Roland Haas):
status: open (was new)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2819/setmask_spherical…
#2818: failing tests with gcc-14
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
I see failing tests, at least TestProlongate maybe others, but not all of them, when compiling the ET \(Landau or development\) with gcc-14.
This
```
./utils/Scripts/MakeThornList --master thornlists/einsteintoolkit.th arrangements/CarpetX/TestProlongate/test/test_cc_co_o1.par >thornlists/test_cc_co_o1.th
```
produces a thornlist one can try this out with. Eg for `test_natural_o7.diffs` the test system reports
```
testprolongate-gf001_count.it000002.x.tsv: substantial differences
significant differences on 68 (out of 39) lines
missing 29 lines in new testprolongate-gf001_count.it000002.x.tsv
maximum absolute difference in column 2 is 0.0166666666666667
maximum relative difference in column 2 is 0.25
```
and looking at the log files there seems to be an issue that only a single refinement level is created compared to 2 when compiled with gcc-13:
```
INFO (CarpetX): Regridding...
INFO (CarpetX): Setting max_grid_size values for all levels before regridding
INFO (CarpetX): ErrorEst patch 0 level 0 INFO (CarpetX): ErrorEst patch 0 level 0 done. Set/clear/total=0/27000/27000=0%/100%/100% INFO (CarpetX): old levels 1, new levels 1
INFO (CarpetX): level 0: 1 boxes, 27000 cells (100%)
```
so this does not seem to be just some sort of roundoff error thing to me.
Diff of the interesting bit of the log file
```diff
INFO (CarpetX): Regridding...
INFO (CarpetX): Setting max_grid_size values for all levels before regridding
INFO (CarpetX): ErrorEst patch 0 level 0
-INFO (CarpetX): ErrorEst patch 0 level 0 done. Set/clear/total=448/26552/27000=2%/98%/100%
-INFO (CarpetX): MakeNewLevelFromCoarse patch 0 level 1
-INFO (CarpetX): SetupLevel patch 0 level 1
-INFO (CarpetX): SetupLevel patch 0 level 1 done.
-INFO (CarpetX): MakeNewLevelFromCoarse patch 0 level 1 done.
-INFO (CarpetX): old levels 1, new levels 2
+INFO (CarpetX): ErrorEst patch 0 level 0 done. Set/clear/total=0/27000/27000=0%/100%/100%
+INFO (CarpetX): old levels 1, new levels 1
INFO (CarpetX): level 0: 1 boxes, 27000 cells (100%)
-INFO (CarpetX): level 1: 1 boxes, 7200 cells (3.333%, 3%)
-INFO (CarpetX): Iteration: 1 time: 0.0333333 delta_time: 0.0166667
-INFO (CarpetX): ScheduleTraverseGH iteration 1 CCTK_BASEGRID
-INFO (CarpetX): CallFunction iteration 1 CCTK_BASEGRID: CarpetX::CarpetX_InitError
-INFO (CarpetX): ScheduleTraverseGH iteration 1 CCTK_POSTREGRID
-INFO (CarpetX): CallFunction iteration 1 CCTK_POSTREGRID: TestProlongate::TestProlongate_Sync
-INFO (CarpetX): SyncGroups TESTPROLONGATE::GF000, TESTPROLONGATE::GF001, TESTPROLONGATE::GF010, TESTPROLONGATE::GF011, TESTPROLONGATE::GF100, TESTPROLONGATE::GF101, TESTPROLONGATE::GF110, TESTPROLONGATE::GF111
INFO (CarpetX): ScheduleTraverseGH iteration 2 CCTK_PRESTEP
INFO (CarpetX): ScheduleTraverseGH iteration 2 CCTK_EVOL
INFO (CarpetX): CallFunction iteration 2 TestProlongate_SetValue: TestProlongate::TestProlongate_Set
```
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2818/failing-tests-wit…
#2813: Allow CarpetX to implement Driver.
Reporter: Steven R. Brandt
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Steven R. Brandt):
Note: Only the PR for CarpetX is still relevant.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2813/allow-carpetx-to-…
#2813: Allow CarpetX to implement Driver.
Reporter: Steven R. Brandt
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
Could you update the list of pull requests one is asked to review, please? Not all the ones listed above are needed anymore apparently.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2813/allow-carpetx-to-…
#2817: update ExternalLibraries-libjpeg to version 9f
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: enhancement
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
Please review
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2817/update-externalli…