#2802: compilation faiulres in TwoPunctures_BBHSF and TwoPunctures_KerrProca with gcc14
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Changes (by Roland Haas):
GCC14 removed implicit pointer casts and requires explicit casts for C in the same manner that C\+\+ requires them.
[https://gcc.gnu.org/gcc-14/porting\_to.html](https://gcc.gnu.org/gcc-14/por…
This affects TwoPunctures and thus all thorns that are derived from TwoPunctures. Typical compile failures are error messages such as:
```
COMPILING Proca/TwoPunctures_KerrProca/src/Newton.c
/Users/rhaas/Cactus/configs/sim/build/TwoPunctures_KerrProca/Newton.c: In function 'TPKP_TestRelax':
/Users/rhaas/Cactus/configs/sim/build/TwoPunctures_KerrProca/Newton.c:287:37: error: passing argument 6 of 'resid' from incompatible pointer type [-Wincompatible-pointer-types]
287 | resid (res, ntotal, dv, F, ncols, cols, JFD);
| ^~~~
| |
| int **
```
This is fixed for TwoPunctures in [https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/18]… but the patch used there does not cleanly apply to the derived codes \(possibly due to some extra lines of code being present\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2802/compilation-faiul…
#2802: compilation faiulres in TwoPunctures_BBHSF and TwoPunctures_KerrProca with gcc14
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
README files list as maintainers:
* @{557058:a2800088-fc6e-4fbe-9a1e-663271f736bd}
* @{557058:65c5f18c-c3ad-4126-bb2b-be0e766b31ef}
* Giuseppe Ficarra \(who I cannot seem to @mention in bitbucket\)
* Cheng-Hsin Cheng \(who I cannot seem to @mention in bitbucket\)
If one of you could take a stab at adding the changes shown in [https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/18]… to TwoPunctures\_KerrProca and TwoPunctures\_BBHSF that would be great.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2802/compilation-faiul…
#2802: compilation faiulres in TwoPunctures_BBHSF and TwoPunctures_KerrProca with gcc14
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Changes (by Roland Haas):
status: open (was new)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2802/compilation-faiul…
#2802: compilation faiulres in TwoPunctures_BBHSF and TwoPunctures_KerrProca with gcc14
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
GCC14 remove implicit pointer casts and requires explicit casts for C in the same manner that C\+\+ requires them.
[https://gcc.gnu.org/gcc-14/porting\_to.html](https://gcc.gnu.org/gcc-14/por…
This affects TwoPunctures and thus all thorns that are derived from TwoPunctures. Typical compile failures are error messages such as:
```
COMPILING Proca/TwoPunctures_KerrProca/src/Newton.c
/Users/rhaas/Cactus/configs/sim/build/TwoPunctures_KerrProca/Newton.c: In function 'TPKP_TestRelax':
/Users/rhaas/Cactus/configs/sim/build/TwoPunctures_KerrProca/Newton.c:287:37: error: passing argument 6 of 'resid' from incompatible pointer type [-Wincompatible-pointer-types]
287 | resid (res, ntotal, dv, F, ncols, cols, JFD);
| ^~~~
| |
| int **
```
This is fixed for TwoPunctures in [https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/18]… but the patch used there does not cleanly apply to the derived codes \(possibly due to some extra lines of code being present\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2802/compilation-faiul…