#2781: Fix bug in debug mode with presync_mode = "off"
Reporter: Samuel Cupp
Status: new
Milestone: ET_2024_05
Version:
Type: bug
Priority: major
Component: Cactus
Currently, `CCTK_HasAccess` only checks access if `presync_mode` is set to `presync_only`. However, with debug on \(`CCTK_DEBUG` is defined\), it instead always checks access.
The first part of this code section asserts that the function has the attribute RDWR:
```
assert(current_function->RDWR);
```
This is incompatible with the form of `CCTKi_CreateRDWRData`, which immediately returns if this parameter is set to `off`, meaning that this attribute is never created. As such, `presync_mode="off"` cannot run in debug mode, which is especially unacceptable for the default parameter setting. If presync is completely off, then it should never enter this section of the code.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2781/fix-bug-in-debug-…
#2780: Include BaikalX and BaikalVacuumX in ET_2024_05 release
Reporter: Samuel Cupp
Status: new
Milestone: ET_2024_05
Version:
Type: enhancement
Priority: major
Component:
`BaikalX` and `BaikalVacuumX` provide the same features of `Baikal` and `BaikalVacuum` for the `CarpetX` driver and are generated using `NRPy+` 2.0.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2780/include-baikalx-a…
#2779: NRPy 2.0 update for Baikal(Vacuum)
Reporter: Samuel Cupp
Status: new
Milestone: ET_2024_05
Version:
Type: bug
Priority: major
Component:
`NRPy+` has been significantly updated during the past year, with the 2.0 release and subsequent updates. This PR changes `Baikal` and `BaikalVacuum` to be generated using the new `NRPy+`. Other than accumulated improvements/changes to code generation, this update has two notable changes:
1. parameters currently don’t restrict their options, as the autogeneration doesn’t yet support this capability
2. `NewRad`'s radpower parameter was changed from `2.0` to `1.0` for `aDD` and `trK`
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2779/nrpy-20-update-fo…
#2778: GRHayLHD(X) update for tabulated EOS support
Reporter: Samuel Cupp
Status: new
Milestone: ET_2024_05
Version:
Type: enhancement
Priority: major
Component:
Previous release only included hybrid EOS for `GRHayLHD` and `GRHayLHDX`, as the tabulated code was still being debugged. This update includes full tabulated support, as well as code simplification/cleanup.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2778/grhaylhd-x-update…
#2777: Upgrade IllinoisGRMHD to use GRHayL
Reporter: Samuel Cupp
Status: new
Milestone:
Version:
Type: enhancement
Priority: major
Component:
This major overhaul of the `IllinoisGRMHD` thorn uses `GRHayL` to implement its original features. In addition, it introduces entropy evolution, tabulated equation of state, and piecewise polytrope support. All con2prim routines provided by `GRHayL` are also automatically supported by the thorn, with control of this behavior governed by the `GRHayLib` thorn.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2777/upgrade-illinoisg…