#2775: FLRWSolver: work around Cactus include search path mangling
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Changes (by Roland Haas):
status: open (was new)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2775/flrwsolver-work-a…
#2775: FLRWSolver: work around Cactus include search path mangling
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
Please review
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2775/flrwsolver-work-a…
#2775: FLRWSolver: work around Cactus include search path mangling
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Cactus' ExternalLibraries system removes the "system" locations from any INC\_DIRS, but not all compilers look at the "well known" locations on their own. So the machine definition files \(in the Einstein Toolkit\) try to work around by setting CPATH which is however not used by gfortran, only by cpp.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2775/flrwsolver-work-a…
#2772: Issues link against Kadath thorns and Intel MKL due to link ordering
Reporter: tootle
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
Looks good to me. Please apply.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2772/issues-link-again…
#2647: incorrect WENO coefficient in GRHydro WENO reconstruction code
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
I did some more tests and incorporated GRHydro’s PPM \( Ian Hawke, Toni Font, Luca Baiotti, Frank Loeffler\) to my test and find that PPM does reconstruction not interpolation.
So WENO \(which does interpolation\) should be changed.
Attached please find the test code and test output.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2647/incorrect-weno-co…
#2772: Issues link against Kadath thorns and Intel MKL due to link ordering
Reporter: tootle
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by tootle):
@{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} Thanks! Indeed that was enough \(with slight modification\) to clean up compiling! I have pushed the latest to KadathThorn master so it will be ready for the next rel
```diff
diff --git a/src/detect.sh b/src/detect.sh
index 9f80ed6..5347190 100755
--- a/src/detect.sh
+++ b/src/detect.sh
@@ -89,9 +89,10 @@ echo "END MESSAGE"
# Pass options to Cactus
echo "BEGIN MAKE_DEFINITION"
echo "KADATH_DIR = ${KADATH_DIR}"
-echo "KADATH_INC_DIRS = ${KADATH_INC_DIRS}"
-echo "KADATH_LIB_DIRS = ${KADATH_LIB_DIRS}"
-echo "KADATH_LIBS = ${KADATH_LIBS}"
+echo "KADATH_INC_DIRS = ${KADATH_INC_DIRS} ${FFTW3_INC_DIRS} ${GSL_INC_DIRS} ${LAPACK_INC_DIRS} ${BOOST_INC_DIRS}"
+echo "KADATH_LIB_DIRS = ${KADATH_LIB_DIRS} ${FFTW3_LIB_DIRS} ${GSL_LIB_DIRS} ${LAPACK_LIB_DIRS} ${BOOST_LIB_DIRS}"
+# keep the order like this, since MKL (LAPACK) can contain a (partial) FFTW3 which conflicts
+echo "KADATH_LIBS = ${KADATH_LIBS} ${FFTW3_LIBS} ${GSL_LIBS} ${LAPACK_LIBS} ${BOOST_LIBS}"
echo "END MAKE_DEFINITION"
echo 'INCLUDE_DIRECTORY $(KADATH_INC_DIRS)'
```
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2772/issues-link-again…