#2697: Include BBH+scalar field initial data code from Canuda in ET
Reporter: Cheng-Hsin Cheng
Status: new
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Roland Haas):
Right now the code for TwoPunctures\_BBHSH in the ET manifest thornlist is from branch `proposal_ET_2023_05` in Canuda. While ok in principle it is a bit strange to not have this eg in either development \(since it saw changes\) or master \(which for Canuda seems to be the “trusted” branch\). If included in the ET the code is expected to be “good' and what the authors use themselves.
Eg for sure for the eventual release the changes must be in an `ET_2023_05` branch which normally should be a child of the trusted branch \(`master` in this case\).
Since the ET manifests `master` branch is not the “trusted good” but the “bleeding edge” branch \(for the ET\), one should be able to pick up bug fixes on ET released thorns in it without changing branches. With `proposal_ET_2023_05` does seems unlikely since I would expect bug fixes to show up either in `development` or `master`of Scalar, wouldn't they?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…
#2697: Include BBH+scalar field initial data code from Canuda in ET
Reporter: Cheng-Hsin Cheng
Status: new
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Thiago Assumpcao):
Hi all, I have reviewed Giuseppe’s most recent changes to TwoPunctures\_BBHSF. The code has very good documentation, is well commented and has tests together with their expect output.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…
#1775: Add Boost to ET
Reporter: Erik Schnetter
Status: new
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
If and when we include Boost in the ET I would strongly advertise to include the whole [thing.Ie](http://thing.Ie) there is one “Boost” thorn that provides everything. Splitting up Boost into `Boost_FileSyste` and `Boost_SpecialFunctions` etc similar to what eg Debian’s package manger does, just buys into lots of dependency issues.
To me the goal of ExternalLibraries is to provide a simple, working fallback and way to for Cactus thorns to interface with the 3rd party libs. It should not become a full featured package management system since we lack resources to maintain that. If this means it is slow the relying on fallback compilation, then so be it. If it is slow all the time even when mostly not used \(OpenSSL is in that category if it compiles\) then this may be an issue.
Generally I feel that expecting a 5minute compile time, without any prior experience and expecting a fully optimized build that way is not realistic for a scientific code. I certain level of experience of the user is expected, at least if they desire an “optimized” build.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1775/add-boost-to-et
#1775: Add Boost to ET
Reporter: Erik Schnetter
Status: new
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component: EinsteinToolkit thorn
Comment (by Wolfgang Kastaun):
Reprimand uses boost only internally for root-solving \(con2prim\) and ODE-solving \(TOV solver\). Both will not be replaced any time soon but those are header-only dependencies that could be distributed with reprimand. Include files exported by reprimand do not include anything from boost so this wont lead to clashes with other code doing the same. The only file operations use hdf5, nothing from boost.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1775/add-boost-to-et
#1881: Unclear error message for parameter file error
Reporter: Erik Schnetter
Status: open
Milestone:
Version: development version
Type: bug
Priority: minor
Component: Cactus
Comment (by Erik Schnetter):
I think that a parameter file should be interpreted in terms of lines. Humans think in terms of lines, and ignoring lines is confusing.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1881/unclear-error-mes…
#1775: Add Boost to ET
Reporter: Erik Schnetter
Status: new
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component: EinsteinToolkit thorn
Comment (by Erik Schnetter):
In CarpetX, we are using some algorithms for non-linear root-finding in con2prim. However, they don’t work on GPUs, and we might want to re-implement them anyway for this reason.
I think that RePrimAnd also uses Boost, probably for filesystem operations \(?\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1775/add-boost-to-et
#2697: Include BBH+scalar field initial data code from Canuda in ET
Reporter: Cheng-Hsin Cheng
Status: new
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Giuseppe Ficarra):
Hi all, after deciding to withdraw NPScalars\_SF from the proposal, I have removed any reference of it from both test and example parameter files of TwoPunctures\_BBHSF. @{61aebb649615eb006f882fe9} do you want to have a look at this? Essentially I removed it completely from the test parameter file \(and updated the output\) and I replaced it with the original NPScalars \(which is already in the ETK\) in the example parameter files. Please use the new branch for the proposal [https://bitbucket.org/canuda/scalar/src/proposal\_ET\_2023\_05/](https://bi… to checkout the updated version of the code.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…
#1775: Add Boost to ET
Reporter: Erik Schnetter
Status: new
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component: EinsteinToolkit thorn
Comment (by Zach Etienne):
I really dislike dependency bloat, as they add more points of failure during compilation and slow compilations greatly. \(I’m cringing at the thought of compiling Boost in serial…\) Returning to Frank’s question: What parts of Boost are needed? Can we just use those?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1775/add-boost-to-et
#1881: Unclear error message for parameter file error
Reporter: Erik Schnetter
Status: open
Milestone:
Version: development version
Type: bug
Priority: minor
Component: Cactus
Comment (by Steven R. Brandt):
The problem is, the grammar does not currently see the par file in terms of lines. It treats whitespace much the same as C does. We could revise it to make whitespace important, but this seems of dubious value at best.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1881/unclear-error-mes…