#732: qc0-mclachlan example parameter file should be more functional
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
-------------------------+--------------------------------------------------
I propose adding wave extraction (using WeylScal4 and Multipole), as well
as puncture tracking using PunctureTracker, to qc0-mclachlan.par.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/732>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#625: CapretIOHDF5 sliced output does not output symmetry points unless it also
outputs buffer points
--------------------------+-------------------------------------------------
Reporter: hinder | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone:
Component: Carpet | Version:
Keywords: CarpetIOHDF5 |
--------------------------+-------------------------------------------------
The parameter CarpetIOHDF5::output_symmetry_points = yes does not work
when CarpetIOHDF5::output_buffer_points = no (the default). This is
probably due to the line
if (not output_buffer_points) {
exts &= allactive;
}
near line 1071 in OutputSlice.cc. I suspect that allactive does not
include the symmetry points. The attached parameter file should be run on
one processor. You can then use
h5dump -d '/GRID::x it=0 tl=0 rl=0' output_symmetry/x.x.h5
Near the top you will see
DATASET "/GRID::x it=0 tl=0 rl=0" {
DATATYPE H5T_IEEE_F64LE
DATASPACE SIMPLE { ( 5 ) / ( 5 ) }
DATA {
(0): 0, 0.1, 0.2, 0.3, 0.4
}
i.e. the first point output is x = 0. For this parameter file, there
should be a symmetry point at x = -0.1. If you modify the parameter file
to use CarpetIOHDF5::output_buffer_points = yes, then the symmetry point
appears in the output.
The workaround is to always use
CarpetIOHDF5::output_buffer_points = yes
if you want to output symmetry points.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/625>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#350: Autogenerating cctk_Loop.h
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
I wrote a perl script to auto-generate the Cactus header file
Cactus/src/include/cctk_Loop.h.The script writes the code to stdout. I
attach it to this ticket, as well as the output it generates.
I suggest to keep this perl script next to its output in the include
directory, and to run it manually whenever required.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/350>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#215: Driscoll&Healy integration for Multipole
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
The attached patch implements a more accurate integration over the sphere,
using an algorithm by Driscoll & Healy. This algorithm uses Gaussian
integration weights, leading (almost) to exponential convergence.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/215>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#512: Run testsuite in "distribute" script
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner: eschnett
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
-------------------------+--------------------------------------------------
Run the testsuite in the distribute script.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/512>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#515: Silently overrides DEBUG and OPTIMISE options
---------------------------+------------------------------------------------
Reporter: barry.wardell | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone:
Component: SimFactory | Version:
Keywords: |
---------------------------+------------------------------------------------
When building a configuration with SimFactory, no matter what is set in
the OptionList it sets the DEBUG and OPTIMISE options based on its own
--optimise and --debug options, which default to enabling optimisation and
disabling debug. This means that even if I have an OptionList with
DEBUG="yes", SimFactory will silently change this to DEBUG="no". This is
very unexpected and should not happen.
I think SimFactory should respect what is set in the OptionList and never
change it. The attached patch disables the overriding of all OptionList
settings.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/515>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#429: Parallelising AEILocalInterp
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
The enclosed patch parallelises AEILocalInterp via OpenMP.
This leads to a slight change in behaviour. Currently, AEILocalInterp
traverses the list of points sequentially, and aborts when the first error
is encountered. After parallelisation, there is no fixed order in which
the points are traversed, and if several errors are encountered, any one
of the errors may be returned, not necessarily the first. I am not aware
of any thorn that would or should rely on such an ordering.
This patch also adds "restrict" and "const" statements that may improve
performance as it gives the compiler more information about dependencies
between pointers.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/429>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#729: RotatingSymmetry90 as applied to pseudo vectors fail
-----------------------------------+----------------------------------------
Reporter: bmundim | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: RotatingSymmetry90 |
-----------------------------------+----------------------------------------
Hi,
doing some tests today with RotatingSymmetry90 today I noticed the
symmetry conditions were not applied correctly for Bvec as defined by
hydrobase:
CCTK_REAL Bvec[3] type = GF Timelevels = 3
tags='ProlongationParameter="HydroBase::prolongation_type"
tensortypealias="U" tensorparity=-1 interpolator="matter"' "Magnetic field
components B^i"
The parity settings used to work until recently. Does anyone know what
could be causing this problem?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/729>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#525: Clean up CCTK_GFINDEX definitions
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
The way in which CCTK_GFINDEX is defined is a bit complex, probably
unnecessarily so. The file cctk.h distinguishes between compilers which
support inlining and compilers which don't. This is probably useless these
days since every compiler supports inlining, and if not, we don't really
expect it to be fast.
If the compiler supports inlining, we define static inline functions,
which may or may not check array indices. If the compiler does not support
inlining, and if CCTK_DEBUG is defined, then we use regular functions
defined in DebugDefines.c, otherwise (i.e. without CCTK_DEBUG) we use
macros.
Overall, the indexing functions are defined three times, including once as
macros. I suggest to simplify this, based on the assumption that every
fast compiler supports inlining. I assume so because (a) the ubiquity of
C++, which relies heavily on inlining, and (b) C99 officially introduced
inlining 12 years ago.
The new setup would have "static inline" definitions (without index
checking) in cctk.h, and would have regular functions (with index
checking) in DebugDefines.c, and would choose between these two
implementations via CCTK_DEBUG.
This would eliminate the macros, and would eliminate the case distinction
based on whether the compiler supports inlining.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/525>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit