#525: Clean up CCTK_GFINDEX definitions
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
The way in which CCTK_GFINDEX is defined is a bit complex, probably
unnecessarily so. The file cctk.h distinguishes between compilers which
support inlining and compilers which don't. This is probably useless these
days since every compiler supports inlining, and if not, we don't really
expect it to be fast.
If the compiler supports inlining, we define static inline functions,
which may or may not check array indices. If the compiler does not support
inlining, and if CCTK_DEBUG is defined, then we use regular functions
defined in DebugDefines.c, otherwise (i.e. without CCTK_DEBUG) we use
macros.
Overall, the indexing functions are defined three times, including once as
macros. I suggest to simplify this, based on the assumption that every
fast compiler supports inlining. I assume so because (a) the ubiquity of
C++, which relies heavily on inlining, and (b) C99 officially introduced
inlining 12 years ago.
The new setup would have "static inline" definitions (without index
checking) in cctk.h, and would have regular functions (with index
checking) in DebugDefines.c, and would choose between these two
implementations via CCTK_DEBUG.
This would eliminate the macros, and would eliminate the case distinction
based on whether the compiler supports inlining.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/525>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#262: make error messages in ReflectionSymmetry more informative
--------------------------------------------+-------------------------------
Reporter: roland.haas@… | Type: enhancement
Status: new | Priority: minor
Milestone: | Component: Cactus
Version: | Keywords:
--------------------------------------------+-------------------------------
this small patch includes the value of ierr in ReflectionSymmetries error
messages
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/262>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#642: Cactus documentation target AllDoc does not make all the documentation
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: optional | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
The Cactus
make AllDoc
command does not make all the documentation - specifically it does not
make the ThornGuide consisting of documentation for all the thorns. It
does make the individual thorn documents. Is there a reason for this?
Perhaps in the past this was a performance issue, but the documentation
can be generated in minutes now, and typically this is not done very
frequently. I think we should change the system so that AllDoc generates
all the documentation.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/642>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#654: Make SphericalSlice part of the ET
-----------------------------------+----------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: ET_2012_05
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
Christian Reisswig has a more general, more useful version of
SphericalSurface called SphericalSlice. This could be made part of the
ET.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/654>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#588: simfactory tries to create the scratch directory when submitting the job
------------------------+---------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
on some machines the desired scratch directory is not visible from the
head node but is compute node local (eg. kraken I think or zwicky for
sure).
Simfactory should not try to create the scratch directory on the node that
runs qsub but rather inside of the runscript or submitscript.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/588>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#733: Provide complete EVO meeting description on web pages
-------------------------------------+--------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: blocker | Milestone:
Component: EinsteinToolkit website | Version:
Keywords: |
-------------------------------------+--------------------------------------
The full EVO meeting descriptions should be on the ET web and wiki pages
and in emails. If e.g. the meeting name is missing, one has to stop evo,
follow the link which restarts evo, etc. If the phone number is missing,
then it is very difficult to call in without using starting EVO.
In particular, the page <http://einsteintoolkit.org/seminars/2012_01_16/>
has only a cryptic url and no other information. The announcing email only
pointed to this page.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/733>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#703: Failure to build h5check on datura
--------------------+-------------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
--------------------+-------------------------------------------------------
When building the Einstein Toolkit thornlist on Datura, the utilities fail
to build with the error:
make[1]: No rule to make target
`/Users/barry/Research/Cactus/AEI/exe/sim/h5check', needed by `utils'.
Stop.
make[1]: Waiting for unfinished jobs....
cc1plus: warning: command line option '-std=c99' is valid for C/ObjC but
not for C++ [enabled by default]
make: *** [sim-utils] Error 2
datura.cfg has
HDF5_DIR = /cluster/hdf5/SL6/1.8.7-intel11.1.072all
Any ideas what might cause this problem?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/703>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#699: FFTW option
---------------------------+------------------------------------------------
Reporter: barry.wardell | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone:
Component: SimFactory | Version:
Keywords: |
---------------------------+------------------------------------------------
Most current OptionLists in SimFactory set the FFTW_DIR option which is
recognized by the Cactus build system. There is now also an
ExternalLibraries/FFTW thorn which instead looks for the option FFTW3_DIR.
Should all OptionLists be modified to set the new variable instead of the
old one? Or is the older FFTW_DIR variable still used/working?
The attached patch renames the option in all optionlists and also removes
the FFTW_LIBS option which is not read by the ExternalLibraries thorn.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/699>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#677: parameter default change in CarpetIOASCII
---------------------------------------------+------------------------------
Reporter: baiotti@… | Owner: eschnett
Type: enhancement | Status: new
Priority: optional | Milestone:
Component: Carpet | Version:
Keywords: CaroetIOASCII parameter default |
---------------------------------------------+------------------------------
I suggest to change the default values of the following parameters from
yes to no:
BOOLEAN output_ghost_points
BOOLEAN out3D_ghosts
BOOLEAN out3D_outer_ghosts
BOOLEAN out1D_d
They refer to debug output and at this time I think they may be off by
default. Some of them are also deprecated.
See also the mailing list thread "questions on CarpetIOASCII".
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/677>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#764: cached output in CarpetIOSCalar
-------------------------+--------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Carpet | Version:
Keywords: |
-------------------------+--------------------------------------------------
the attached patch uses a set of ostringstreams to cache CarpetIOScalar's
output and writes it to disk in chunks of io_chunk_size bytes.
The code reproduces the results of the pre-change thorn in the included
test suite.
If this is accepted I'll give adding the same functionality to IOASCII a
try.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/764>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit