#1389: Trac html code remains bold after end of comment
----------------------------------+-----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit trac | Version: development version
Keywords: |
----------------------------------+-----------------------------------------
the comment in https://trac.einsteintoolkit.org/ticket/1365#comment:13
accidentally turns on bold script which persists for the remaining
comments (at least using Firefox, Chroma or Opera). It would be better to
reset everything to normal at the end of each comment.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1389>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1015: increase file size limit
----------------------------------+-----------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit trac | Version:
Keywords: |
----------------------------------+-----------------------------------------
Could we increase the size limit for attached files, please? Right now it
seems to be 256k which is regularly too small if I have to attach a patch
with test data. I don't really like splitting up patches into a code patch
(uncompressed) and a gzipped data patch for the test data all the time. It
is just very very error prone.
At least for logged in users.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1015>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#907: TRAC: allow to create a ticket with review state
----------------------------------+-----------------------------------------
Reporter: bmundim | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit trac | Version:
Keywords: TRAC |
----------------------------------+-----------------------------------------
Sometimes we want to create a ticket with an attached patch and assign the
ticket to be reviewed. That should be possible with only one "modify
ticket". Currently we need to create the ticket with the attachment and
then modify the ticket afterwards to review state. The problem is that
sometimes we forget to change to review state. It would be nice to do it
all at once.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/907>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1044: Gnuplot Cactus visualisation page has multiple issues
----------------------------+-----------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus website | Version:
Keywords: |
----------------------------+-----------------------------------------------
The page http://cactuscode.org/documentation/visualization/gnuPlot/ has
the following problems:
* The instructions for viewing multi-iteration 1D data from the
IOASCII thorn do not work. Since the iterations are separated by only a
single blank line, you cannot use the "index" option in the Gnuplot "plot"
command as the instructions tell you to do. I suspect that either the
output format or Gnuplot itself has changed since the instructions were
written. Erik suggests using some form of "every" to visualise this data
in Gnuplot.
* This page renders poorly in both Safari (webkit) and Firefox
(gecko). The light blue boxes containing text to be typed have a strange
artefact on the left side, and the initial paragraph is wrapped poorly.
* All of the links in the table of contents are broken.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1044>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#450: Output elapsed times for test cases
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
To ensure that Cactus test cases don't run for too long, and to identify
those that do, we should output the run time for all test cases together
with their results.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/450>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#229: Using a nonexistent header file should lead to an error message
--------------------+-------------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
--------------------+-------------------------------------------------------
If I have the following in my interface.ccl,
USES INCLUDE: vectors.h
but no thorn in my thornlist provides this header file, there is no error
at compile time. Further, if I #include this file in my source file, an
empty file is included, which means that again I don't get an error. The
first indication that something is wrong is that the contents of the
header file are not available, which makes debugging the problem with the
thornlist very confusing.
I propose that the CST should emit a fatal error if one of the thorns
tries to use a header file which does not exist.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/229>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1382: Cactus should disable collapse sections automatically for C _and_ Fortran
--------------------------+-------------------------------------------------
Reporter: knarf | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: ET_2013_05
Keywords: openmp flesh |
--------------------------+-------------------------------------------------
Currently, Cactus disables OpenMP collapse due to compiler problems either
when specified explicitly in the option list, or when finding certain
compilers that are known to have this kind of problem. However, the latter
is only done for C and C++, but not Fortran. In addition, Cactus aborts
compilation if collapse is not explicitly disabled, but affected compilers
are found, with a message that collapse is disabled for C, but not for
Fortran, indicating an error in the option list. While the first is true
since Cactus actually disabled the collapse sections because it found a
faulty compiler, the latter is not, since the option list doesn't mention
collapse sections at all and isn't inconsistent.
This means in the end that the auto-detections isn't really working in the
way that is was intended: that Cactus does things automatically if faulty
compilers are found. Instead, Cactus currently aborts, with a message that
isn't leading users in the right direction. A workaround right now is to
define CCTK_DISABLE_OMP_COLLAPSE for both C and Fortran in the option
list.
The proposed patch removes this error message, and instead adds the same
compiler-detection for Fortran, that is already present for C and C++. The
advantage would be that option lists wouldn't need to define anything.
Cactus would either disable the collapse sections for all languages, or
for none.
If accepted, I propose to backport this change, in addition to applying it
to the development version. The patch was created using ET_2013_05.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1382>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1374: C++ complex implementation fails to compile
----------------------+-----------------------------------------------------
Reporter: knarf | Owner:
Type: defect | Status: new
Priority: critical | Milestone: ET_2013_05
Component: Cactus | Version: development version
Keywords: |
----------------------+-----------------------------------------------------
When compiling I get:
{{{
COMPILING
/home/knarf/Cactus/arrangements/CactusCoastal/Funwave/src/declare.cc
In file included from /usr/include/c++/4.7/complex:46:0,
from /home/knarf/Cactus/src/include/cctk_Types.h:40,
from /home/knarf/Cactus/src/include/cctk_Groups.h:34,
from
/home/knarf/Cactus/arrangements/CactusCoastal/Funwave/src/cctk_declare.h:9,
from
/home/knarf/Cactus/configs/sim/build/Funwave/declare.cc:1:
/usr/include/c++/4.7/cmath: In function ‘constexpr float std::abs(float)’:
/usr/include/c++/4.7/cmath:90:16: error: declaration of C function
‘constexpr float std::abs(float)’ conflicts with
/usr/include/c++/4.7/cmath:84:3: error: previous declaration ‘constexpr
double std::abs(double)’ here
/usr/include/c++/4.7/cmath: In function ‘constexpr long double
std::abs(long double)’:
/usr/include/c++/4.7/cmath:94:22: error: declaration of C function
‘constexpr long double std::abs(long double)’ conflicts with
/usr/include/c++/4.7/cmath:90:3: error: previous declaration ‘constexpr
float std::abs(float)’ here
/usr/include/c++/4.7/cmath:94:22: error: declaration of C function
‘constexpr long double std::abs(long double)’ conflicts with
/usr/include/c++/4.7/cmath:84:3: error: previous declaration ‘constexpr
double std::abs(double)’ here
/usr/include/c++/4.7/cmath: At global scope:
/usr/include/c++/4.7/cmath:98:3: error: template with C linkage
}}}
This seems to be caused by cctk_Groups.h going into "C" linkage, then
including cctk_Types.h which includes <complex> when compiled with C++.
The system complex implementation however (at least in CXX0X mode) uses
templates, which aren't allowed with "C" linkage.
I use gnu g++ version 4.7 with -std=gnu++0x.
Applying the following patch to src/include/cctk_Types.h solves the
problem for me:
{{{
Index: cctk_Types.h
===================================================================
--- cctk_Types.h (revision 5021)
+++ cctk_Types.h (working copy)
@@ -37,7 +37,9 @@
/* Declarations for complex types */
#ifdef __cplusplus
+extern "C++" {
# include <complex>
+}
#endif
#ifdef HAVE_CCTK_REAL16
}}}
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1374>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1397: make attempt to change non-steerable parameters at recovery fatal error
-------------------------+--------------------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: optional | Milestone:
Component: Cactus | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
currently Cactus ignores, almost silently (there is a L2 warning "Non-
steerable parameter 'ADMBase::initial_lapse' is not set from the parameter
file but recovered from the checkpoint file"), any attempt to steer non-
steerable parameters during checkpoint recovery. I wonder if it would be
better to abort or at least make this a Lev1 warning. The comments in
cckt_Warnlevel.h say:
{{{
#define CCTK_WARN_ABORT 0 /* abort the Cactus run */
#define CCTK_WARN_ALERT 1 /* the results of this run will be wrong,
*/
/* and this will surprise the user, */
/* but we can still continue the run */
#define CCTK_WARN_COMPLAIN 2 /* the user should know about this, */
/* but the problem is not terribly */
/* surprising */
#define CCTK_WARN_PICKY 3 /* this is for small problems that can */
/* probably be ignored, but that careful
*/
/* people may want to know about */
#define CCTK_WARN_DEBUG 4 /* these messages are probably useful */
/* only for debugging purposes */
}}}
since having a parameter being ignored is indeed surprising for most users
:-) .
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1397>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit