#2332: piraha does not allow variable expansion in ActiveThorns
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Comment (by Steven R. Brandt):
No. Obviously, nothing should happen before the release.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2332/piraha-does-not-a…
#2580: GetComponents assumes that default branch name is "master"
Reporter: Roland Haas
Status: new
Milestone:
Version: development version
Type: bug
Priority: minor
Component: GetComponents
When using a stanza like this:
```
!TARGET = $ARR
!TYPE = git
!URL = git@github.com:rhaas/Foo.git
!REPO_BRANCH = main
!REPO_PATH= $2
!CHECKOUT =
Foo/Foo
```
GetComponents fails with:
```
> bin/GetComponents --verbose --root . thornlists/grhydrox.th
-----------------------------------------------------------------
Checking out module: Foo/Foo
from repository: git@github.com:rhaas/Foo.git
into: ./arrangements
Executing: mkdir -p './repos'
Executing: git clone git@github.com:rhaas/Foo.git './repos/Foo'
Cloning into './repos/Foo'...
Executing: git tag -l
In: './repos/Foo'
Executing: git checkout --track -b main origin/main
In: './repos/Foo'
fatal: A branch named 'main' already exists.
Executing: mv './repos/Foo' './repos/Foo.branch.failed.1'
Warning: Could not checkout Foo/Foo, unable to switch to branch main. Any existing symlinks to Foo/Foo will be broken
```
This can be made to work by leaving out the `REPO_BRANCH` option altogether, which is doable but not ideal.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2580/getcomponents-ass…
#2173: Test "Poisson equation" example
Reporter: Roland Haas
Status: open
Milestone: ET_2021_11
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Comment (by Miguel Gracia):
I updated the website and uploaded the results. I ran the example using a machine configured with _Intel\(R\) Xeon\(R\) Gold 6226R CPU @ 2.90GHz and 64Gb of ram._
@{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} the link [https://bitbucket.org/einsteintoolkit/manifest/raw/ET\_2021\_11/einsteintoo… doesn’t exist so I left the ET\_2021\_05 one instead.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2173/test-poisson-equa…
#2579: CT_MultiLevel implicitly requires CT_Analytic
Reporter: Gabriele Bozzola
Status: new
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
I am trying to solve a Poisson equation with `CT_MultiLevel` but without including `CT_Analytic` \(which is advertised as an helper thorn\). I found that this cannot be done because `CT_MultiLevel` explicitly calls the restriction operations on grid functions defined in `CT_Analytic`. For example, in `CT_RelaxError.cc`:
```
CT_Restrict(CCTK_PASS_CTOC, "CT_MultiLevel::psi");
CT_Restrict(CCTK_PASS_CTOC, "CT_MultiLevel::coeffs");
CT_Restrict(CCTK_PASS_CTOC, "CT_Analytic::CT_testK");
CT_Restrict(CCTK_PASS_CTOC, "CT_Analytic::CT_testdxK");
CT_Restrict(CCTK_PASS_CTOC, "CT_Analytic::CT_testdyK");
CT_Restrict(CCTK_PASS_CTOC, "CT_Analytic::CT_testdzK");
CT_Restrict(CCTK_PASS_CTOC, "CT_Analytic::CT_testc1");
CT_Restrict(CCTK_PASS_CTOC, "CT_Analytic::CT_testc2");
```
If you don’t have `CT_Analytic` as an active thorn, the run will abort. \(Are these restrictions needed?\)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2579/ct_multilevel-imp…
#2578: Kranc, Cactus, and MPI linking issues
Reporter: Nicholas Hugh Olsen
Status: new
Milestone:
Version: ET_2021_05
Type: bug
Priority: minor
Component: Cactus
Comment (by Roland Haas):
If it’s Kranc specific then you may consider using Kranc’s mailng list and issue tracker as mentioned on the Kranc website: [http://kranccode.org/support.html](http://kranccode.org/support.html)
Having said that, the Kranc authors tend to see ET tickets and may speak up.
```
~$ ls /usr/lib/x86_64-linux-gnu/openmpi/lib/
libmca_common_monitoring.so libmpi_cxx.so libopen-rte.so
libmca_common_ofi.so libmpi_java.so liboshmem.so
libmca_common_ompio.so libmpi_mpifh.so ompi_monitoring_prof.so
libmca_common_sm.so libmpi_usempi_ignore_tkr.so openmpi3
libmca_common_ucx.so libmpi_usempif08.so pkgconfig
libmca_common_verbs.so libompitrace.so
libmpi.so libopen-pal.so
```
ie there is a library `mpi_cxx` in addition to `mpi`.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2578/kranc-cactus-and-…
#2332: piraha does not allow variable expansion in ActiveThorns
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Comment (by Roland Haas):
@{557058:1671c5c3-29cc-4e83-9850-a152d33a6235} any progress on this?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2332/piraha-does-not-a…
#2575: online thorn documentation only lists thorns active in thorn list
Reporter: Roland Haas
Status: invalid
Milestone: ET_2021_11
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit website
Changes (by Roland Haas):
status: invalid (was new)
Comment (by Roland Haas):
I was mistaken. All thorn documentation is build for all thorns in arrangements no matter whether they are in a thornlist or not.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2575/online-thorn-docu…
#2577: CactusTutorial.ipynb contains code only suitable or tutorial server
Reporter: Roland Haas
Status: new
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit Virtual Machine
The tutorial notebook is intended for both use inside of the tutorial server \(and docker image\) as well as users' own jupyer notebook server in their account and finally as a read-only, offline version.
The current notebook contains instances of code that will fail or do dangerous things on a user’s laptop. Namley:
```python
import scrolldown
```
will fail unless a Python module `scrolldown` is available. This should be encased in a `try:... except ModuleNotFoundError` block.
And
```shell
cd ~/
rm -fr ~/Cactus
tar xzf ~etuser/Cactus.tar.gz
```
which is very dangerous since it will remove any `Cactus` directory in a user’s $HOME which is a bad thing to do for offline use where users may want to use a different directory \(eg GW150914 or so\). The tarbal will also only exist on the notebook server and thus `tar` will fail on private jupyter notebook servers or in offline use. This can confuse potential new users that expect to be able to enter each command in the notebook and thus be able to run Cactus.
This cell should be protect by some bash-level if statements that check if it is being run on the notebook server and a comment that this cell will only be used on the notebook server added to the cell as a shell comment \(so that it cannot be lost\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2577/cactustutorialipy…
#2551: include RePriMand in the ET
Reporter: Roland Haas
Status: open
Milestone: ET_2021_11
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Wolfgang Kastaun):
```
@article{Kastaun:2020uxr,
author = "Kastaun, Wolfgang and Kalinani, Jay Vijay and Ciolfi, Riccardo",
title = "{Robust Recovery of Primitive Variables in Relativistic Ideal Magnetohydrodynamics}",
eprint = "2005.01821",
archivePrefix = "arXiv",
primaryClass = "gr-qc",
doi = "10.1103/PhysRevD.103.023018",
journal = "Phys. Rev. D",
volume = "103",
number = "2",
pages = "023018",
year = "2021"
}
```
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2551/include-reprimand…
#2551: include RePriMand in the ET
Reporter: Roland Haas
Status: open
Milestone: ET_2021_11
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Roland Haas):
It’s not super important \(since RePrimAnd is not yet compiled by default\) you may consider to hook yourself up to the ET commits mailing list \(like the ET thorns do\) by setting up [commits@einsteintoolkit.org](mailto:commits@einsteintoolkit.org) as the recipient of push event emails in [https://github.com/GITHUB\_USER\_NAME/REPO\_NAME/settings/notifications/edi… .
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2551/include-reprimand…
#2538: Inclusion of kuibit
Reporter: Gabriele Bozzola
Status: open
Milestone: ET_2021_11
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Roland Haas):
It’s not super important \(since kuibit is analysis not ET thorn\) you may consider to hook yourself up to the ET commits mailing list \(like the ET thorns do\) by setting up [commits@einsteintoolkit.org](mailto:commits@einsteintoolkit.org) as the recipient of push event emails in [https://github.com/GITHUB\_USER\_NAME/REPO\_NAME/settings/notifications/edi… .
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2538/inclusion-of-kuib…
#2538: Inclusion of kuibit
Reporter: Gabriele Bozzola
Status: open
Milestone: ET_2021_11
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Gabriele Bozzola):
> Usually the suggested citations are secondary publications or publications that describe specific aspects that not all users will use.
I see. Without `numpy`, `scipy`, and `h5py`, `kuibit` would not exist. Therefore, I personally always cite them, and I would recommend anyone that uses `kuibit` to do the same. \(\`matplotlib\` is not as important in `kuibit`: you can use 95 % of the available features without it and use your preferred plotting library instead\)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2538/inclusion-of-kuib…
#2538: Inclusion of kuibit
Reporter: Gabriele Bozzola
Status: open
Milestone: ET_2021_11
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Roland Haas):
Thank you. You can certainly add the scipy and numpy citations as suggested ones. If you do list citations for kuibit’s dependencies \(typically not done, those dependenicies would have their own list\) you may also consider the matplotlib citation \(which they actually request, [https://matplotlib.org/3.1.1/citing.html](https://matplotlib.org/3.1.1/citi…):
```tex
@Article{Hunter:2007,
Author = {Hunter, J. D.},
Title = {Matplotlib: A 2D graphics environment},
Journal = {Computing in Science \& Engineering},
Volume = {9},
Number = {3},
Pages = {90--95},
abstract = {Matplotlib is a 2D graphics package used for Python for
application development, interactive scripting, and publication-quality
image generation across user interfaces and operating systems.},
publisher = {IEEE COMPUTER SOC},
doi = {10.1109/MCSE.2007.55},
year = 2007
}
```
though the entry itself already exists in einsteintoolkit.bib. Usually the suggested citations are secondary publications or publications that describe specific aspects that not all users will use.
Independent of this, adding the numpy and scipy entries \(with or without suggested-for\) to einsteintoolkit.bib seems like a good idea. Thanks for looking them up.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2538/inclusion-of-kuib…
#2538: Inclusion of kuibit
Reporter: Gabriele Bozzola
Status: open
Milestone: ET_2021_11
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Gabriele Bozzola):
You can use this citation key:
```tex
@article{Bozzola:2021hus,
requested-for = {kuibit},
author = "Bozzola, Gabriele",
title = "{kuibit: Analyzing Einstein Toolkit simulations with Python}",
eprint = "2104.06376",
archivePrefix = "arXiv",
primaryClass = "gr-qc",
doi = "10.21105/joss.03099",
journal = "J. Open Source Softw.",
volume = "6",
number = "60",
pages = "3099",
year = "2021"
}
```
`kuibit` relies upon `numpy`, `scipy`, and `h5py`
```
@article{Harris:2020xlr,
suggested-for = {kuibit},
author = {Charles R. Harris and K. Jarrod Millman and St{\'{e}}fan J.
van der Walt and Ralf Gommers and Pauli Virtanen and David
Cournapeau and Eric Wieser and Julian Taylor and Sebastian
Berg and Nathaniel J. Smith and Robert Kern and Matti Picus
and Stephan Hoyer and Marten H. van Kerkwijk and Matthew
Brett and Allan Haldane and Jaime Fern{\'{a}}ndez del
R{\'{i}}o and Mark Wiebe and Pearu Peterson and Pierre
G{\'{e}}rard-Marchant and Kevin Sheppard and Tyler Reddy and
Warren Weckesser and Hameer Abbasi and Christoph Gohlke and
Travis E. Oliphant},
title = "{Array programming with NumPy}",
eprint = "2006.10256",
archivePrefix = "arXiv",
primaryClass = "cs.MS",
doi = "10.1038/s41586-020-2649-2",
journal = "Nature",
volume = "585",
number = "7825",
pages = "357--362",
year = "2020"
}
@article{Virtanen:2019joe,
suggested-for = {kuibit},
author = {Virtanen, Pauli and Gommers, Ralf and Oliphant, Travis E. and
Haberland, Matt and Reddy, Tyler and Cournapeau, David and
Burovski, Evgeni and Peterson, Pearu and Weckesser, Warren and
Bright, Jonathan and {van der Walt}, St{\'e}fan J. and
Brett, Matthew and Wilson, Joshua and Millman, K. Jarrod and
Mayorov, Nikolay and Nelson, Andrew R. J. and Jones, Eric and
Kern, Robert and Larson, Eric and Carey, C J and
Polat, {\.I}lhan and Feng, Yu and Moore, Eric W. and
{VanderPlas}, Jake and Laxalde, Denis and Perktold, Josef and
Cimrman, Robert and Henriksen, Ian and Quintero, E. A. and
Harris, Charles R. and Archibald, Anne M. and
Ribeiro, Ant{\^o}nio H. and Pedregosa, Fabian and
{van Mulbregt}, Paul and {SciPy 1.0 Contributors}},
title = "{SciPy 1.0--Fundamental Algorithms for Scientific Computing in Python}",
eprint = "1907.10121",
archivePrefix = "arXiv",
primaryClass = "cs.MS",
doi = "10.1038/s41592-019-0686-2",
journal = "Nature Meth.",
volume = "17",
pages = "261",
year = "2020"
}
```
Unfortunately, h5py does not have a recommended citation.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2538/inclusion-of-kuib…
#2538: Inclusion of kuibit
Reporter: Gabriele Bozzola
Status: open
Milestone: ET_2021_11
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Roland Haas):
You can request up to one \(not a hard rule but strongly encouraged\) citations that people should use when using RePrimAnd, as well as multiple \(any number, but you may provide indication under which circumstances which ones are suggested\) suggested citations. Those will be listed on: [https://www.einsteintoolkit.org/citation.html](https://www.einsteintoolkit.…
To provide the citation please provide bibtex entries to be included in einsteintoolkit.bib \(in the manifest repo\) that should look something like this:
```perl
@Misc{Kranc:web,
suggested-for ="McLachlan/ML_BSSN",
key = {Kranc},
title = {{Kranc}: {Kranc} Assembles Numerical Code},
url = {http://kranccode.org/},
}
@Misc{EinsteinToolkit:2021_05,
requested-for ={EinsteinToolkit},
author = {Zachariah Etienne and Steven R. Brandt and Peter Diener and William E. Gabella and Miguel Gracia-Linares and Roland Haas and Atul Kedia and Miguel Alcubierre and Daniela Alic and Gabrielle Allen and Marcus Ansorg and Maria Babiuc-Hamilton and Luca Baiotti and Werner Benger and Eloisa Bentivegna and Sebastiano Bernuzzi and Tanja Bode and Gabriele Bozzola and Brockton Brendal and Bernd Bruegmann and Manuela Campanelli and Federico Cipolletta and Giovanni Corvino and Samuel Cupp and Roberto De Pietri and Harry Dimmelmeier and Rion Dooley and Nils Dorband and Matthew Elley and Yaakoub El Khamra and Joshua Faber and Toni Font and Joachim Frieben and Bruno Giacomazzo and Tom Goodale and Carsten Gundlach and Ian Hawke and Scott Hawley and Ian Hinder and E. A. Huerta and Sascha Husa and Sai Iyer and Daniel Johnson and Thorsten Kellermann and Andrew Knapp and Michael Koppitz and Pablo Laguna and Gerd Lanferman and Frank L{\"o}ffler and Joan Masso and Lars Menger and Andre Merzky and Jonah Maxwell Miller and Mark Miller and Philipp Moesta and Pedro Montero and Bruno Mundim and Andrea Nerozzi and Scott C. Noble and Christian Ott and Ravi Paruchuri and Denis Pollney and David Radice and Thomas Radke and Christian Reisswig and Luciano Rezzolla and David Rideout and Matei Ripeanu and Lorenzo Sala and Jascha A Schewtschenko and Erik Schnetter and Bernard Schutz and Ed Seidel and Eric Seidel and John Shalf and Ken Sible and Ulrich Sperhake and Nikolaos Stergioulas and Wai-Mo Suen and Bela Szilagyi and Ryoji Takahashi and Michael Thomas and Jonathan Thornburg and Malcolm Tobias and Aaryn Tonita and Paul Walker and Mew-Bing Wan and Barry Wardell and Leonardo Werneck and Helvi Witek and Miguel Zilh{\~a}o and Burkhard Zink and Yosef Zlochower},
title = {The Einstein Toolkit},
month = may,
year = 2021,
note = {To find out more, visit http://einsteintoolkit.org},
publisher = {Zenodo},
version = {The "Lorentz" release, ET\_2021\_05},
doi = {10.5281/zenodo.4884780},
url = {https://doi.org/10.5281/zenodo.4884780}
}
@article{Noble:2005gf,
requested-for = {WVUThorns/IllinoisGRMHD},
author = "Noble, Scott C. and Gammie, Charles F. and McKinney,
Jonathan C. and Del Zanna, Luca",
title = "{Primitive variable solvers for conservative general
relativistic magnetohydrodynamics}",
journal = "Astrophys. J.",
volume = "641",
pages = "626-637",
doi = "10.1086/500349",
year = "2006",
eprint = "arXiv:astro-ph/0512420",
SLACcitation = "%%CITATION = ASTRO-PH/0512420;%%",
}
```
the preferred entry format is SPIRES-like, in that SPIRES keys are strongly recommended but we list all authors. The top of [einsteintoolkit.th](http://einsteintoolkit.th) explains the convention: [https://bitbucket.org/einsteintoolkit/manifest/raw/master/einsteintoolkit.b…
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2538/inclusion-of-kuib…
#2551: include RePriMand in the ET
Reporter: Roland Haas
Status: open
Milestone: ET_2021_11
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Roland Haas):
You also can request up to one \(not a hard rule but strongly encouraged\) citations that people should use when using RePrimAnd, as well as multiple \(any number, but you may provide indication under which circumstances which ones are suggested\) suggested citations. Those will be listed on: [https://www.einsteintoolkit.org/citation.html](https://www.einsteintoolkit.…
To provide the citation please provide bibtex entries to be included in einsteintoolkit.bib \(in the manifest repo\) that should look something like this:
```perl
@Misc{Kranc:web,
suggested-for ="McLachlan/ML_BSSN",
key = {Kranc},
title = {{Kranc}: {Kranc} Assembles Numerical Code},
url = {http://kranccode.org/},
}
@article{Noble:2005gf,
requested-for = {WVUThorns/IllinoisGRMHD},
author = "Noble, Scott C. and Gammie, Charles F. and McKinney,
Jonathan C. and Del Zanna, Luca",
title = "{Primitive variable solvers for conservative general
relativistic magnetohydrodynamics}",
journal = "Astrophys. J.",
volume = "641",
pages = "626-637",
doi = "10.1086/500349",
year = "2006",
eprint = "arXiv:astro-ph/0512420",
SLACcitation = "%%CITATION = ASTRO-PH/0512420;%%",
}
```
the preferred entry format is SPIRES-like, in that SPIRES keys are strongly recommended but we list all authors. The top of [einsteintoolkit.th](http://einsteintoolkit.th) explains the convention: [https://bitbucket.org/einsteintoolkit/manifest/raw/master/einsteintoolkit.b…
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2551/include-reprimand…
#2551: include RePriMand in the ET
Reporter: Roland Haas
Status: open
Milestone: ET_2021_11
Version: development version
Type: enhancement
Priority: major
Component:
Comment (by Wolfgang Kastaun):
I have just pushed recent changed to the public repository. Those include:
* minor changes triggered by code review
* updated natural constants and option to use own
* tex documentation, now pointing to new online location on github pages
* minor changes to Roland’s thorn building \(no library version in archive name, .tar instead .tar.xz\)
* Placed copy of EOS file creation Python module in src/utils
* fixing build problems of standalone library \(not relevant for ET thorn\)
The online documentation is now on [https://wokast.github.io/RePrimAnd/index.html](https://wokast.github.io/ReP…
I have checked that ET builds from scratch with a fresh clone of the public repo on my system.
Once we decide to include a given commit \(hopefully this one\) I will tag it as a release so it gets archived on Zenodo as well, with corresponding DOI. The DOI could then be mentioned in the ET release notes.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2551/include-reprimand…
#2175: Test "Single, stable neutron star" example
Reporter: Roland Haas
Status: open
Milestone: ET_2021_11
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Comment (by Gabriele Bozzola):
The kuibit code to reproduce the plot should be something like \(not tested\):
```python
from kuibit.simdir import SimDir
import matplotlib.pyplot as plt
PATH = ....
rho = SimDir(PATH).timeseries.maximum['rho']
plt.plot(rho / rho(0))
plt.savefig("density.pdf")
```
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2175/test-single-stabl…