#2585: The website does not have citations recommendations for codes in the canuda suite
Reporter: Gabriele Bozzola
Status: new
Milestone:
Version: development version
Type: bug
Priority: minor
Component: EinsteinToolkit website
Comment (by Roland Haas):
Thank you for reporting these and providing fixes.
It turns out that these steps are already on the ET release process page \(two items actually\):
\* [https://docs.einsteintoolkit.org/et-docs/Release\_Process#create\_branches]…
\* and earlier:
> Update einsteintoolkit.bib \([https://bitbucket.org/einsteintoolkit/manifest/src/master/](https://bitbucket.org/einsteintoolkit/manifest/src/master/)\) with
>
> Requested and suggested citations for all thorns in thorn list \(_10 minutes_\).
> Latest release info and DOI \(from Zenodo entry above\)
so the issue is that steps were skipped \(or “thorns” was taken to really mean only “thorns” and not “ET components”\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2585/the-website-does-…
#1278: Handle inf and nan in parameter file parser
Reporter: Erik Schnetter
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Comment (by Roland Haas):
Sure. Steve pointed out \(offline communication\) that `expressions.par` in TestPar does indeed contain `nan` . Somehow `git log -G 'nan'` does not find it. Closing the ticket since it has already been fixed.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1278/handle-inf-and-na…
#1278: Handle inf and nan in parameter file parser
Reporter: Erik Schnetter
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Comment (by Steven R. Brandt):
So `TestPar.par` does contain a test with an `inf` and `call.cc` does check for `inf` and `nan`. The test passes. As near as I can tell, this ticket ought to be closed.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1278/handle-inf-and-na…
#1278: Handle inf and nan in parameter file parser
Reporter: Erik Schnetter
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Comment (by Roland Haas):
Not sure if that test ever actually tested for NaNs. At least \`git log -G \[Nn\]\[Aa\]\[Nn\]' does not find anything. There is a test in NaNChecker that had to use some extra code to produce NaNs for it to find in git hash [837d426](https://bitbucket.org/cactuscode/cactusutils/commits/837d4260c2608… "NaNChecker: use internally generated NaNs in test case" of [cactusutils](https://bitbucket.org/cactuscode/cactusutils) .
Should be enough to have a regex looking for `nan` and `[+-]inf` where the current regex expects the numeric part I suspect and \(possibly\) some extra code in the C\+\+ code to convert those to NaN and inf, if that is not automatically done by the routine used to convert real number strings to double values.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1278/handle-inf-and-na…
#1278: Handle inf and nan in parameter file parser
Reporter: Erik Schnetter
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Comment (by Steven R. Brandt):
I don’t see a test failure. Maybe something changed?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1278/handle-inf-and-na…
#1437: Missing option for deterministic noise in CactusNumerical/Noise
Reporter: Frank Löffler
Status: new
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component: EinsteinToolkit thorn
Comment (by Steven R. Brandt):
Possible hackathon task
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1437/missing-option-fo…
#2332: piraha does not allow variable expansion in ActiveThorns
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: Cactus
Comment (by Steven R. Brandt):
Possible hackathon task.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2332/piraha-does-not-a…