Trac August 2022

trac@lists.einsteintoolkit.org

1 participants
121 discussions

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 12: `init_tools.F90` contains routines from another library “MESCALINE” but does not contain a link to the library or author attribution. Possible software license violation. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Comment 4: I’m rather confused as to why `random.F90` exists. It seems to be a custom RNG. Why not use something off the shelf? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 11: `random.F90` contains a code snippet “found on stackexchange”, but does not contain a link to the SE article. Complete attribution needed. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 10: A more detailed description of what `par/FLRW_powerspectrum_restart.par` does in that file would be appreciated. It’s rather unusual and probably violates ET standards to have a separate parameter file just for restarting from checkpoints. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 9: Running `par/FLRW_powerspectrum.par` results in a _FORTRAN runtime error_, as `/path/to/flrwsolver/powerspectra/FLRW_matterpower_synchronous_z1000.dat` does not exist. It would be better to check for the file’s existence in the Einstein Toolkit CCTK\_\*ERROR infrastructure, and would be a great opportunity to tell the user how to generate this file. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 8: There are two `FLRW_singlemode.par` files: one in `par/` and one in `test/`. These seem to be two very different files, so adjusting the filename to be more descriptive would help new users browsing these example parameter files. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Comment 3: Instead of storing simfactory configs for machines within a thorn’s repo, consider contributing them to `SimFactory` . -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 7: There are two, slightly different, copies of the `Plot_ET_data.ipynb` tutorial in the repo: one in `doc/tutorial` and one in `tools/`. This could make the thorn more difficult to maintain moving forward. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Comment 2: `documentation.tex` only refers to one Python script in `tools`, despite there being 5 scripts in that directory _and_ a Jupyter notebook. It would be so nice to reference these in the documentation, as they are likely to be very useful to new users. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2549: inlcude FLRWSolver in ET
by Zach Etienne 25 Aug '22

25 Aug '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Zach Etienne): Issue 6: I couldn’t find reference to the example power spectrum \(see `powerspectrum/`\) in the documentation. This would be a useful addition. Also I liked that when I went into `powerspectrum/` I was greeted with a `README` file explaining the basics of what this was. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac August 2022