Trac September 2022

trac@lists.einsteintoolkit.org

1 participants
67 discussions

#2616: Add NRPyEllipticET to the Einstein Toolkit
by Cheng-Hsin Cheng 15 Sep '22

15 Sep '22

#2616: Add NRPyEllipticET to the Einstein Toolkit Reporter: Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Cheng-Hsin Cheng): @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} yes, I would like to confirm that we concluded the review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2616/add-nrpyelliptice…

1 0

#2616: Add NRPyEllipticET to the Einstein Toolkit
by Leonardo Werneck 15 Sep '22

15 Sep '22

#2616: Add NRPyEllipticET to the Einstein Toolkit Reporter: Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Leonardo Werneck): Hi all. Here are the updates made to `NRPyEllipticET` based on the reviewers' comments: * A brief `README` file has been added; * `uuGF`'s description has been updated in `interface.ccl`; * `info_output_freq`'s comment has been updated in `param.ccl`; * `N2`'s “forbidden value” has been removed, as it was unused; * `initialize_offdiagonal_metric_to_zero` was indeed an old parameter and has been removed; * All instances of `fprintf(stderr,...); exit();` have been replaced by either `CCTK_*ERROR` or `CCTK_*WARN`; * We have added a new parameter called `residual_integration_radius`, with a proper description of what it does; * Some of the algorithms are hard to describe using brief code comments. We recommend looking at the NRPy\+ Jupyter notebooks for the complete description of such algorithms; * Thank you for pointing out that `CFL_FACTOR` was missing in `find_timestep.c`; this was actually a bug fix; * Unfortunately the code in `wavespeed_gf_all_points.c` depends on `dt` \(the result of `find_timestep.c`\) at every grid point and thus the two cannot be decoupled; * The reason why the `rfm` parameters have the unused attribute is similar to the reason why parameters have the attribute, i.e., not every function that uses the `rfm` includes will use _all_ of the included parameters, which could lead to warnings; * All instances of `__attribute__((unused))` have been replaced with `CCTK_ATTRIBUTE_UNUSED`; * I have removed the empty files in `conformally_flat_BBH/rfm_files/` manually and am trying to figure out a way of automating this; * `apply_bcs_curvilinear_radiation.c` and `set_Cparameters-SIMD.h` have been removed for now; * `xx_to_Cart.c` and `set_Cparameters-nopointer.h` have _not_ been removed. Although currently unused by the thorn, they provide useful functionality that new users might want to use. A general comment: the Jupyter notebook that generates `NRPyEllipticET` was very outdated. I am currently pushing on getting it up to speed, but at the moment we do not have a notebook that regenerates the latest version of the thorn. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2616/add-nrpyelliptice…

1 0

#2602: include Regge-Wheeler-Zerilli gauge self-force code in ET
by Peter Diener 15 Sep '22

15 Sep '22

#2602: include Regge-Wheeler-Zerilli gauge self-force code in ET Reporter: Samuel Cupp Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Other Comment (by Peter Diener): Samuel has addresses all the comments raised. Now just need to generate the documentation with Ford, but that will not change any code so should be safe to do later. So in essence the review has concluded. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2602/include-regge-whe…

1 0

#2549: inlcude FLRWSolver in ET
by Roland Haas 15 Sep '22

15 Sep '22

#2549: inlcude FLRWSolver in ET Reporter: Roland Haas Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Comment (by Roland Haas): Just catching up with things \(for half a day and then I will falling behind again\), I cannot comment on the actual physics. Certainly the description of the Courant factor is correct. There are certainly bits and pieces in the ET that will make assumptions like “lapse is about 1 at large radii” but those are mostly say gravitational wave extraction which is less useful in this situation \(since it also implicitly assumes a Schwarzschild like background for the waves\). Having a large lapse should be fine, if I am not mistaken then eg Zach has a trick to smooth out initial gauge dynamics by temporarily setting a very large lapse even for black hole simulations \(though likely only near the black holes\). Anyway, the existing codes in the ET should \(fingers crossed\) all handle 0 < lapse < infty at least in cases where this makes sense. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2549/inlcude-flrwsolve…

1 0

#2616: Add NRPyEllipticET to the Einstein Toolkit
by Roland Haas 15 Sep '22

15 Sep '22

#2616: Add NRPyEllipticET to the Einstein Toolkit Reporter: Status: new Milestone: Version: Type: enhancement Priority: major Component: Comment (by Roland Haas): @Cheng-Hsin Cheng, @Guiseppe Ficarra could you confirm, for the record, that the review concluded? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2616/add-nrpyelliptice…

1 0

#2485: include complex and real scalar evolution code from Canuda in ET
by Roland Haas 15 Sep '22

15 Sep '22

#2485: include complex and real scalar evolution code from Canuda in ET Reporter: Roland Haas Status: open Milestone: Version: Type: task Priority: major Component: Comment (by Roland Haas): @Taishi Ikeda could you confirm for the record that the review concluded? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2485/include-complex-a…

1 0

#2602: include Regge-Wheeler-Zerilli gauge self-force code in ET
by Roland Haas 15 Sep '22

15 Sep '22

#2602: include Regge-Wheeler-Zerilli gauge self-force code in ET Reporter: Samuel Cupp Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Other Comment (by Roland Haas): @{557058:f7fd5133-6eee-4385-a5e5-3e03342a0b24} could you state \(for the record\) that the review concluded, please? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2602/include-regge-whe…

1 0

#2602: include Regge-Wheeler-Zerilli gauge self-force code in ET
by Samuel Cupp 14 Sep '22

14 Sep '22

#2602: include Regge-Wheeler-Zerilli gauge self-force code in ET Reporter: Samuel Cupp Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Other Comment (by Samuel Cupp): Tests were added, along with errors \(with messages\) for invalid choices of lmin and lmax. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2602/include-regge-whe…

1 0

#2602: include Regge-Wheeler-Zerilli gauge self-force code in ET
by Samuel Cupp 13 Sep '22

13 Sep '22

#2602: include Regge-Wheeler-Zerilli gauge self-force code in ET Reporter: Samuel Cupp Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Other Comment (by Samuel Cupp): I’m uncommenting lines 557-580, as some of that code is necessary for the mechanisms that allow for turning on the source smoothly. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2602/include-regge-whe…

1 0

#2602: include Regge-Wheeler-Zerilli gauge self-force code in ET
by Samuel Cupp 13 Sep '22

13 Sep '22

#2602: include Regge-Wheeler-Zerilli gauge self-force code in ET Reporter: Samuel Cupp Status: new Milestone: ET_2022_05 Version: development version Type: enhancement Priority: major Component: Other Comment (by Samuel Cupp): I have pushed changes that address most of these points. I am working on test cases now and am basing them off of the scalar code tests. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2602/include-regge-whe…

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac September 2022