#2692: Inclusion of FUKA importer thorns
Reporter: tootle
Status: resolved
Milestone: ET_2023_05
Version: ET_2023_05
Type: proposal
Priority: major
Component: EinsteinToolkit thorn
Changes (by Samuel Cupp):
status: resolved (was new)
Comment (by Samuel Cupp):
These thorns are now included as part of the Toolkit in the ET_2023_05 release.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…
#2175: Test "Single, stable neutron star" example
Reporter: Roland Haas
Status: open
Milestone: ET_2023_05
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Comment (by Peter Diener):
I have rerun the gallery simulation and found no difference between the new results and the old ones. I also ran at three higher resolutions and have added that data to the new plot. I have also added a convergence plot using the three highest resolutions. The Kuibit script has been update to produce both the density and the convergence plots.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2175/test-single-stabl…
#2731: check for incomplete perl install when use requests parallel checkout
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: GetComponents
Comment (by Roland Haas):
@{557058:1671c5c3-29cc-4e83-9850-a152d33a6235} could I ask you to review this one for the weekly review, please?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2731/check-for-incompl…
#2731: check for incomplete perl install when use requests parallel checkout
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: GetComponents
Changes (by Roland Haas):
responsible: [] (was [])
assignee: Steven R. Brandt (was Roland Haas)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2731/check-for-incompl…
#2176: Test "Binary neutron star" example
Reporter: Roland Haas
Status: open
Milestone: ET_2023_05
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Comment (by Roland Haas):
I updated the website and the data. The gallery example now uses higher resolution.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2176/test-binary-neutr…
#2731: check for incomplete perl install when use requests parallel checkout
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: GetComponents
Comment (by Roland Haas):
Please review. After the 2023\_05 release.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2731/check-for-incompl…
#2731: check for incomplete perl install when use requests parallel checkout
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: GetComponents
**Panagiotis Iosif** in [https://lists.einsteintoolkit.org/pipermail/users/2023-May/008923.html](htt… encountered and issue when passed `--parallel` to GetComponents on a cluster where the Perl installation is very minimal and lacks Perl’s standard Thread package. This has happened before in some Docker image as well \(so that now we include Perl as one of the packages to install with apt/yum/dnf\).
Since this is apparently also an issue on clusters, pull request
[https://github.com/gridaphobe/CRL/pull/13](https://github.com/gridaphobe/CR…
provides an error message when this happens. Leaving out the explicit `--parallel` option lets one download the ET.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2731/check-for-incompl…
#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
Reporter: Gabriele Bozzola
Status: open
Milestone:
Version: development version
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Leonardo Werneck):
After reviewing the issue more carefully, I think it is more prudent to fix it for the November release, as there won’t be enough time to fully test the code in time for this release. One possible solution is to modify IllinoisGRMHD’s `schedule.ccl` to add the con2prim function to the `HydroBase_Con2Prim` bin when `TmunuBase::stress_energy_at_RHS="no"`, e.g.,
```
if(stress_energy_at_RHS)
{
schedule IllinoisGRMHD_conserv_to_prims in AddToTmunu after compute_B_and_Bstagger_from_A
{
LANG: C
} "Compute primitive variables from conservatives. This is non-trivial, requiring a Newton-Raphson root-finder."
schedule IllinoisGRMHD_outer_boundaries_on_P_rho_b_vx_vy_vz in AddToTmunu after IllinoisGRMHD_conserv_to_prims
{
# We must sync {P,rho_b,vx,vy,vz} here.
SYNC: grmhd_primitives_allbutBi
LANG: C
} "Apply outflow-only, flat BCs on {P,rho_b,vx,vy,vz}. Outflow only == velocities pointed inward from outer boundary are set to zero."
}
else
{
schedule IllinoisGRMHD_conserv_to_prims in HydroBase_Con2Prim after compute_B_and_Bstagger_from_A
{
LANG: C
} "Compute primitive variables from conservatives. This is non-trivial, requiring a Newton-Raphson root-finder."
schedule IllinoisGRMHD_outer_boundaries_on_P_rho_b_vx_vy_vz in HydroBase_Con2Prim after IllinoisGRMHD_conserv_to_prims
{
# We must sync {P,rho_b,vx,vy,vz} here.
SYNC: grmhd_primitives_allbutBi
LANG: C
} "Apply outflow-only, flat BCs on {P,rho_b,vx,vy,vz}. Outflow only == velocities pointed inward from outer boundary are set to zero."
}
```
This fixes the scheduling problem, but the code will still keep adding to `Tmunu` unless one also sets `IllinoisGRMHD::update_tmunu = "no"` in the parfile.
Could you please test this to see if it provides the functionality that you seek @{557058:4b0c8315-696b-4d2e-92da-2da5fea9e8d4} ? If I misunderstood something, please let me know.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…
#2174: Test "Multi Patch Scalar Wave Equation" example
Reporter: Roland Haas
Status: open
Milestone: ET_2023_05
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Comment (by jakedoherty):
I’ve pushed the changes for 2023 May Release and I got the exact same results using 56 cores on Frontera in a little over a minute. I generated my own session files for visualization.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2174/test-multi-patch-…