Trac February 2025

trac@lists.einsteintoolkit.org

1 participants
77 discussions

Start a nNew thread

#2853: AHFinderDirect_import_mask() needs an OpenMP pragma
by Zach Etienne 11 Feb '25

11 Feb '25

1 0

#2821: update PETSc to 3.21.5
by Roland Haas 09 Feb '25

09 Feb '25

#2821: update PETSc to 3.21.5 Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2821/update-petsc-to-3…

1 0

#2821: update PETSc to 3.21.5
by Roland Haas 09 Feb '25

09 Feb '25

#2821: update PETSc to 3.21.5 Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Applied as git hash [6918f071](https://bitbucket.org/cactuscode/cactus/commits/6918f0714a3d3fa4f… "Cactus: regenerate configure" of [cactus](https://bitbucket.org/cactuscode/cactus) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2821/update-petsc-to-3…

1 0

#2842: Silo captures incorrect LIBS values on second CST run
by Roland Haas 09 Feb '25

09 Feb '25

#2842: Silo captures incorrect LIBS values on second CST run Reporter: Roland Haas Status: resolved Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2842/silo-captures-inc…

1 0

#2842: Silo captures incorrect LIBS values on second CST run
by Roland Haas 09 Feb '25

09 Feb '25

#2842: Silo captures incorrect LIBS values on second CST run Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): Applied as git hash [6918f071](https://bitbucket.org/cactuscode/cactus/commits/6918f0714a3d3fa4f… "Cactus: regenerate configure" of [cactus](https://bitbucket.org/cactuscode/cactus) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2842/silo-captures-inc…

1 0

#2853: AHFinderDirect_import_mask() needs an OpenMP pragma
by Zach Etienne 07 Feb '25

07 Feb '25

#2853: AHFinderDirect_import_mask() needs an OpenMP pragma Reporter: Zach Etienne Status: new Milestone: Version: Type: enhancement Priority: minor Component: Comment (by Zach Etienne): After the patch, the profiling of **AHFinderDirect** improves significantly: * **AHFinderDirect\_find\_horizons**: ~56% → ~69% of total **AHFinderDirect** runtime * **AHFinderDirect\_import\_mask**: ~31% → 18% of total **AHFinderDirect** runtime * **AHFinderDirect\_store**: ~13% → ~13% of total **AHFinderDirect** runtime Note that I’m running with 8 MPI ranks and 12 \(OpenMP\) cores per rank. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2853/ahfinderdirect_im…

1 0

#2852: No error for multiple definitions of an interface group.
by Roland Haas 07 Feb '25

07 Feb '25

#2852: No error for multiple definitions of an interface group. Reporter: Steven R. Brandt Status: open Milestone: ET_2025_05 Version: Type: bug Priority: major Component: Cactus Changes (by Roland Haas): status: open (was new) Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2852/no-error-for-mult…

1 0

#2852: No error for multiple definitions of an interface group.
by Roland Haas 07 Feb '25

07 Feb '25

#2852: No error for multiple definitions of an interface group. Reporter: Steven R. Brandt Status: new Milestone: ET_2025_05 Version: Type: bug Priority: major Component: Cactus Changes (by Roland Haas): responsible: [] (was ) assignee: Steven R. Brandt (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2852/no-error-for-mult…

1 0

#2853: AHFinderDirect_import_mask() needs an OpenMP pragma
by Zach Etienne 07 Feb '25

07 Feb '25

#2853: AHFinderDirect_import_mask() needs an OpenMP pragma Reporter: Zach Etienne Status: new Milestone: Version: Type: enhancement Priority: minor Component: Comment (by Zach Etienne): [https://bitbucket.org/einsteintoolkit/einsteinanalysis/pull-requests/24](ht… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2853/ahfinderdirect_im…

1 0

#2853: AHFinderDirect_import_mask() needs an OpenMP pragma
by Zach Etienne 07 Feb '25

07 Feb '25

#2853: AHFinderDirect_import_mask() needs an OpenMP pragma Reporter: Zach Etienne Status: new Milestone: Version: Type: enhancement Priority: minor Component: While comparing the performance of **AHFinderDirect** with my new apparent horizon finder thorn, **ET\_BHaHAHA** \(“the ET implementation of the BlackHoles@Home Apparent Horizon Algorithm”\), I observed the following runtime distribution in **AHFinderDirect**: * **AHFinderDirect\_find\_horizons**: ~56% of total runtime * **AHFinderDirect\_import\_mask**: ~31% of total runtime * **AHFinderDirect\_store**: ~13% of total runtime #### Context These measurements were taken using a slightly modified version of the **GW150914 BBH gallery example**, replacing **ML\_BSSN** with **BaikalVacuum** at a slightly higher resolution. Runtime data is based on **TimerReport cumulative runtime**. Granted, the import\_mask function takes up 0.2% of the total runtime at this find-horizon cadence, but that it takes a significant fraction of the AHFinderDirect runtime at all is simply unacceptable. #### Issue: AHFinderDirect\_import\_mask Performance The **AHFinderDirect\_import\_mask** function is particularly inefficient. It consists of a simple **3D loop** that **lacks OpenMP parallelization**, significantly impacting performance. Here’s the entire function \(with comments removed\): ``` extern "C" void AHFinderDirect_import_mask(CCTK_ARGUMENTS) { DECLARE_CCTK_ARGUMENTS_AHFinderDirect_import_mask DECLARE_CCTK_PARAMETERS assert(ahmask != 0); for (int k=0; k<cctk_lsh[2]; ++k) for (int j=0; j<cctk_lsh[1]; ++j) for (int i=0; i<cctk_lsh[0]; ++i) { const int ind = CCTK_GFINDEX3D(cctkGH,i,j,k); ahmask[ind] = 0; if (use_mask) then ahmask[ind] = fabs(emask[ind] - 1.0) > 0.01; } } ``` I would strongly recommend adding an OpenMP pragma, as follows: ``` diff --git a/AHFinderDirect/src/driver/find_horizons.cc b/AHFinderDirect/src/driver/find_horizons.cc index 67838eb..4ca0702 100644 --- a/AHFinderDirect/src/driver/find_horizons.cc +++ b/AHFinderDirect/src/driver/find_horizons.cc @@ -98,6 +98,7 @@ DECLARE_CCTK_PARAMETERS assert(ahmask != 0); +#pragma omp parallel for for (int k=0; k<cctk_lsh[2]; ++k) for (int j=0; j<cctk_lsh[1]; ++j) for (int i=0; i<cctk_lsh[0]; ++i) ``` ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2853/ahfinderdirect_im…

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac February 2025