#955: Don't #define restrict in thorns -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- The following thorns #define restrict. This is now handled by the flesh, so the thorns should not do that any more:
arrangements/CactusNumerical/Slab/src/slab.cc:53:# define restrict CCTK_CXX_RESTRICT arrangements/CactusUtils/OpenCLRunTime/src/defs.hh:11:# define restrict CCTK_CXX_RESTRICT arrangements/EinsteinEvolve/NewRad/src/extrap.cc:8:# define restrict CCTK_CXX_RESTRICT arrangements/EinsteinEvolve/NewRad/src/newrad.cc:8:# define restrict CCTK_CXX_RESTRICT
#955: Don't #define restrict in thorns ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review
#955: Don't #define restrict in thorns ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
Also, all places that use CCTK_RESTRICT should now use "restrict".
#955: Don't #define restrict in thorns ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
Ok to apply (given that the flesh now defines restrict).
#955: Don't #define restrict in thorns ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => reviewed_ok
#955: Don't #define restrict in thorns ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied.
#955: Don't #define restrict in thorns ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+---------------------------------------
Comment (by hinder):
I assume that this means that people updating these thorns will also need to update the flesh. If that is the case, please can you send an email to the usual lists to warn people of the error messages they are likely to see and the required fix?
trac@lists.einsteintoolkit.org
-
Einstein Toolkit