#1143: Optimise calls to CCTK_VarDataPtr -------------------------+-------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: Cactus | Version: Keywords: | -------------------------+-------------------------------------------------- Cactus calls CCTK_VarDataPtr each time DECLARE_CCTK_ARGUMENTS is executed for each grid function. This routine performs string looks and is thus unreasonably expensive.
The attached patch remembers variable indices in static variables.
#1143: Optimise calls to CCTK_VarDataPtr --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: new => review
#1143: Optimise calls to CCTK_VarDataPtr --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by sbrandt):
* status: review => reviewed_ok
Comment:
Changes the previous method of doing hundreds of string compares on each function invocation to finding and caching the variable index in a static variable.
#1143: Optimise calls to CCTK_VarDataPtr --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: major | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit