[Einstein Toolkit] #1275: simfactory knows about TerminationTrigger but not TriggerTerminationManual

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1315:...

[Einstein Toolkit] #283: Update...

Einstein Toolkit

2 Mar 2013 2 Mar '13

10:20 p.m.

#1275: simfactory knows about TerminationTrigger but not TriggerTerminationManual -------------------------+-------------------------------------------------- Reporter: knarf | Owner: eschnett Type: enhancement | Status: new Priority: minor | Milestone: Component: SimFactory | Version: Keywords: | -------------------------+-------------------------------------------------- Currently, simfactory knows about TerminationTrigger but not TriggerTerminationManual and sets the corresponding max_walltime parameter correctly for the first but not the second. This small patch does so also for the second thorn (found in Zelmani).

This should be independent of the question why there are two of these thorns (which would be a good one to answer), or whether one of them could be retired or both of them merged. They are currently both used in production and simfactory should know about both.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

2 Mar 2 Mar

10:21 p.m.

#1275: simfactory knows about TerminationTrigger but not TriggerTerminationManual --------------------------+------------------------------------------------- Reporter: knarf | Owner: eschnett Type: enhancement | Status: review Priority: minor | Milestone: ET_2013_05 Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):

* status: new => review * version: => development version * milestone: => ET_2013_05

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3 Mar 3 Mar

10:26 a.m.

Comment (by eschnett):

There should not be two thorns that essentially do the same thing. Simfactory should support only the thorn found in the Einstein Toolkit.

TriggerTerminationManual can be handled via an additional command line argument to Simfactory; something like {{{ --replace=TriggerTerminationManual::walltime=@WALLTIME@ }}} should do the trick. ("--replace" replaces options and parameter values.)

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:24 a.m.

Comment (by hinder):

I would argue that SimFactory should not be in the business of supporting individual thorns; it shouldn't really know anything about Cactus either! Perhaps it would be better for SimFactory to expose this sort of information in some other way. I would suggest environment variables which can be picked up by the thorn, but there are probably issues with ensuring that the full environment is available on every MPI process.

Why can the user not just put @WALLTIME@ into their parameter file? That is the solution that I always use. Is this because they might want to use their parameter file without simfactory?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:43 a.m.

Comment (by knarf):

Replying to [comment:3 hinder]:

...

I would argue that SimFactory should not be in the business of

supporting individual thorns.

I agree. The command line option might work, but I wouldn't want to type this every time, or forget doing so.

...

Why can the user not just put @WALLTIME@ into their parameter file?

That is the solution that I always use. Is this because they might want to use their parameter file without simfactory?

Yes, in 'my' case this is the case as well. It it much more convenient to have parameter files also work without simfactory.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:33 p.m.

Comment (by eschnett):

Ideally, this replacement would be in defs.local.ini, and probably also in the Einstein Toolkit example for the defs.local.ini.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2:19 p.m.

Comment (by rhaas):

Yes, keeping hard-code file manipulation code out of simfactories executables sounds like a good idea.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2:46 p.m.

Comment (by knarf):

Following this, the code for TerminationTrigger should also go to a configuration file?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3:08 p.m.

Comment (by eschnett):

I was thinking of adding a facility whereby one can add arbitrary "replace" statements to defs.local.ini. The code handling TerminationTrigger should then also go there (or maybe into defs.ini).

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

25 Apr 25 Apr

9:13 a.m.

Comment (by knarf):

Good idea. Could we apply the patch until this new facility is in place?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:29 a.m.

Comment (by eschnett):

I am not convinced that it is a good idea to support a new thorn that is not part of the Einstein Toolkit. Does TriggerTerminationManual have any features that make it superior to TerminationTrigger? Is there a plan to propose it for inclusion into the Einstein Toolkit?

At the moment, having a private modification to Simfactory seems like a workable solution. In the long run, the best course of action may be to switch to using TerminationTrigger.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:33 a.m.

Comment (by knarf):

Ideally, the two thorns should be merged. I proposed the patch since TriggerTerminationManual seems to be used quite a bit especially at Caltech, and the patch is so trivial. Also, I don't think simfactory must only support thorns included in the ET. On the other hand, I agree that some pressure to actually merge the two thorns might do good in the end. :)

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:41 a.m.

Comment (by eschnett):

TerminationTrigger started as a merge and cleanup of TriggerTerminationManual and another, similar thorn at the AEI. Unfortunately, people never switched...

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:12 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10 May 10 May

1:26 p.m.

#1275: simfactory knows about TerminationTrigger but not TriggerTerminationManual --------------------------+------------------------------------------------- Reporter: knarf | Owner: eschnett Type: enhancement | Status: closed Priority: minor | Milestone: ET_2013_05 Component: SimFactory | Version: development version Resolution: wontfix | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):

* status: review => closed * resolution: => wontfix

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1275#comment:13 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

4900

Age (days ago)

4968

Last active (days ago)

trac@lists.einsteintoolkit.org

13 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit