[Einstein Toolkit] #1870: ET_2015_11_v0 of McLachlan does regenerate code for ca6fe74 "McLachlan_BSSN.m: Make evolveA steerable"
#1870: ET_2015_11_v0 of McLachlan does regenerate code for ca6fe74 "McLachlan_BSSN.m: Make evolveA steerable" -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: McLachlan backport | -----------------------------------+---------------------------------------- the release branch claims to make ML_BSSN::evolveA steerable but fails to actually do so in the generated code. Commit 0b38cba1f9ee9fce3f1ed2543295266efb86107e of McLachlan fixes this on master.
#1870: ET_2015_11_v0 of McLachlan does regenerate code for ca6fe74 "McLachlan_BSSN.m: Make evolveA steerable" ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: McLachlan backport ------------------------------------+--------------------------------------- Changes (by anonymous):
* status: new => review
Comment:
Ok to backport [https://bitbucket.org/einsteintoolkit/mclachlan/commits/0b38cba1f9ee9fce3f1e... 0b38cba1f9ee9fce3f1ed2543295266efb86107e] to the release branch?
#1870: ET_2015_11_v0 of McLachlan does regenerate code for ca6fe74 "McLachlan_BSSN.m: Make evolveA steerable" ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: McLachlan backport ------------------------------------+--------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
Comment:
The patch changes the param.ccl of multiple thorns, of which only McLachlan/ML_CCZ4 is actually in the Einstein Toolkit (but due to git all are in the release branch). Changing McLachlan/ML_CCZ4 is fine with me, and changing the others as well as quite obviously this makes sense even outside the ET.
#1870: ET_2015_11_v0 of McLachlan does regenerate code for ca6fe74 "McLachlan_BSSN.m: Make evolveA steerable" ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: McLachlan backport ------------------------------------+---------------------------------------
Comment (by rhaas):
Applied as git hash 0b38cba of McLachlan of master. Also applied 70863af (which is an obvious bugfix) accidentally.
#1870: ET_2015_11_v0 of McLachlan does regenerate code for ca6fe74 "McLachlan_BSSN.m: Make evolveA steerable" ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: McLachlan backport ------------------------------------+--------------------------------------- Changes (by knarf):
* status: reviewed_ok => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit