[Einstein Toolkit] #763: LSUThorns/Vectors/src test.cc doesn't compile with "REAL_PRECISION = 4"
#763: LSUThorns/Vectors/src test.cc doesn't compile with "REAL_PRECISION = 4" -----------------------------------+---------------------------------------- Reporter: jtao | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- COMPILING /home/jtao/workspace/CactusDev/Cactus/arrangements/LSUThorns/Vectors/src/test.cc /home/jtao/workspace/CactusDev/Cactus/configs/ml/build/Vectors/test.cc:154:39: error: macro "vec4_store_nta_partial" requires 5 arguments, but only 2 given /home/jtao/workspace/CactusDev/Cactus/configs/ml/build/Vectors/test.cc: In function ‘void Vectors_Test(cGH*)’: /home/jtao/workspace/CactusDev/Cactus/configs/ml/build/Vectors/test.cc:153:46: error: ‘vec4_store_partial_prepare’ was not declared in this scope In file included from /home/jtao/workspace/CactusDev/Cactus/configs/ml/build/Vectors/test.cc:1:0: /home/jtao/workspace/CactusDev/Cactus/arrangements/LSUThorns/Vectors/src/vectors.h:65:37: error: ‘vec4_store_nta_partial’ was not declared in this scope
#763: LSUThorns/Vectors/src test.cc doesn't compile with "REAL_PRECISION = 4" ------------------------------------+--------------------------------------- Reporter: jtao | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
This works for me.
Are you using the development version of Vectors? Is your checkout up to date?
#763: LSUThorns/Vectors/src test.cc doesn't compile with "REAL_PRECISION = 4" ------------------------------------+--------------------------------------- Reporter: jtao | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by jtao):
I checked it out from https://svn.cct.lsu.edu/repos/numrel/LSUThorns/Vectors/trunk Not sure if that is the development version. My checkout is up to date at revision 52. The error doesn't appear with REAL_PRECISION = 8 though.
The latest commitment is not so long ago. 2012-02-06T16:59:05.753257Z 52 eschnett
#763: LSUThorns/Vectors/src test.cc doesn't compile with "REAL_PRECISION = 4" ------------------------------------+--------------------------------------- Reporter: jtao | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by barry.wardell):
It sounds like the problem is that Jian is using the non-SSE version of the single precision vectors code which is in vectors-4-default.h. This is indeed missing some code which was added recently for other architectures. The attached patch adds this missing code.
#763: LSUThorns/Vectors/src test.cc doesn't compile with "REAL_PRECISION = 4" ------------------------------------+--------------------------------------- Reporter: jtao | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
Please apply both.
#763: LSUThorns/Vectors/src test.cc doesn't compile with "REAL_PRECISION = 4" ------------------------------------+--------------------------------------- Reporter: jtao | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by barry.wardell):
Applied.
Jian, can you confirm if the latest svn trunk now compiles for you?
#763: LSUThorns/Vectors/src test.cc doesn't compile with "REAL_PRECISION = 4" ------------------------------------+--------------------------------------- Reporter: jtao | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by jtao):
It now compiles. Thanks !
#763: LSUThorns/Vectors/src test.cc doesn't compile with "REAL_PRECISION = 4" ------------------------------------+--------------------------------------- Reporter: jtao | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by jtao):
* status: new => review
#763: LSUThorns/Vectors/src test.cc doesn't compile with "REAL_PRECISION = 4" ------------------------------------+--------------------------------------- Reporter: jtao | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by barry.wardell):
* status: review => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit