[Einstein Toolkit] #1390: parameter file parser aborts when findeing first error

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1875:...

[Einstein Toolkit] #2041: new...

Einstein Toolkit

26 Jun 2013 26 Jun '13

3:43 a.m.

#1390: parameter file parser aborts when findeing first error --------------------+------------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: Cactus | Version: development version Keywords: | --------------------+------------------------------------------------------- The attached parfile contains multiple errors (one per line).

However the parameter file parser only reports the first one, then stops. This makes verifying parfiles for correctness hard. It might be good to defer aborting until the end of the file or until a larger number of parsing errors were encountered.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1390 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

16 Mar 16 Mar

12:55 p.m.

#1390: parameter file parser aborts when findeing first error ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------

Comment (by rhaas):

This still applies even with the piraha based parser. It is particularly annoying on clusters where one cannot run {{{cactus_sim -S fail.par}}} on the login nodes (eg Cray machines).

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1390#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3:25 p.m.

Comment (by sbrandt):

I don't know a generic way to recover from a syntax error. My experience is that when compilers try to do this, usually only the first error message is meaningful. I can make specific syntax errors recoverable, however. I could make piraha recover from the specific errors in this file.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1390#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

5:03 p.m.

Comment (by sbrandt):

Take a look at the multiple_syntax_errors branch of the flesh and see if it does what you want.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1390#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6 Apr 6 Apr

8:42 a.m.

#1390: parameter file parser aborts when findeing first error ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: sbrandt Type: defect | Status: accepted Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by sbrandt):

* owner: => sbrandt * status: new => accepted

Comment:

Can I put this in review?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1390#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12 Apr 12 Apr

10:19 a.m.

#1390: parameter file parser aborts when findeing first error ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: sbrandt Type: defect | Status: accepted Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------

Comment (by rhaas):

You can certainly put it up for review. The review report may or may not be "please apply" in the end (by whoever ends up reviewing it which does not have to be me :-)). For review though please either link the pull request here or provide a diff to look at.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1390#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

17 Apr 17 Apr

10:45 a.m.

#1390: parameter file parser aborts when findeing first error ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: sbrandt Type: defect | Status: review Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by sbrandt):

* status: accepted => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1390#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

20 Apr 20 Apr

2:29 p.m.

#1390: parameter file parser aborts when findeing first error ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: sbrandt Type: defect | Status: reopened Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):

* status: review => reopened

Comment:

I added comments on the code to a pull request for the branch that you can find here: https://bitbucket.org/cactuscode/cactus/pull-requests/37 /multiple-syntax-errors-enabled-through-a/diff

Testing functionality I find that it still aborts after the first error, even for the fail.par file attached in this ticket. In fact I have been unable to make it produce more than one syntax error. Would you be able to provide a parameter file where the change in the code makes a difference, please?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1390#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

21 Apr 21 Apr

8:30 a.m.

#1390: parameter file parser aborts when findeing first error ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: sbrandt Type: defect | Status: review Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by sbrandt):

* status: reopened => review

Comment:

Roland, I replied to your comments and issues and pushed a new revision to the branch.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1390#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

17 May 17 May

10:35 a.m.

#1390: parameter file parser aborts when findeing first error ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: sbrandt Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):

* status: review => reviewed_ok

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1390#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

19 May 19 May

1:11 p.m.

#1390: parameter file parser aborts when findeing first error ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: sbrandt Type: defect | Status: closed Priority: major | Milestone: Component: Cactus | Version: development version Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by sbrandt):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

Fixed in 441d62bb72f86519a3e1cc947155671f19803fc0 of https://bitbucket.org/cactuscode/cactus.git

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1390#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

3429

Age (days ago)

4852

Last active (days ago)

trac@lists.einsteintoolkit.org

10 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit