[Einstein Toolkit] #383: SimFactory 1 does not create source directory on login

List overview All Threads
Download

newer

older

[Einstein Toolkit] #422: Cactus...

[Einstein Toolkit] #242: build...

Einstein Toolkit

4 Apr 2011 4 Apr '11

10:34 a.m.

#383: SimFactory 1 does not create source directory on login ------------------------+--------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: new Priority: major | Milestone: ET_2011_05 Component: SimFactory | Version: Keywords: | ------------------------+--------------------------------------------------- If I run "sim login <machine>" to a machine where the remote source directory does not exist, the login fails with

bash: line 0: cd: /nics/d/home/hinder/Cactus/etrelease: No such file or directory Connection to kraken-gsi2.nics.teragrid.org closed.

If I run a "sim sync" first, then a subsequent sim login works correctly.

I propose that simfactory should create the required directories before logging in.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/383 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

4 Apr 4 Apr

10:58 a.m.

#383: SimFactory 1 does not create source directory on login -------------------------+-------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: new Priority: major | Milestone: ET_2011_05 Component: SimFactory | Version: Resolution: | Keywords: -------------------------+--------------------------------------------------

Comment (by eschnett):

Creating the directory would allow people to log in, but would still not allow people to execute any simfactory commands there (since simfactory is not yet available on the remote system).

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/383#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:08 a.m.

Comment (by knarf):

Right - the existence of a remote source tree shouldn't be required to login to that machine.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/383#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12:43 p.m.

Comment (by hinder):

We could insist that all commands except sync need a sync to have been performed first. In which case we should give an error message along the lines of "No remote simfactory installation found. Please run sim sync before attempting to access a remote system using simfactory." However, since login is easy to support, it might be a good idea for login to be allowed even without a remote source directory being present.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/383#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12:52 p.m.

Comment (by knarf):

Indeed. It would be extremely useful to be able to use 'sim login', e.g. to debug problems with a sync itself. Why does 'login' depend on a sync anyway? Is it because it might automatically 'put you' in the right directory? If so, then this could be caught and commented on with a warning in case the directory didn't exist - instead of an error and no remote shell in the end.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/383#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:25 p.m.

Comment (by hinder):

The only error was that the directory didn't exist on login. I think login should just create the directory.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/383#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2:12 p.m.

Comment (by mthomas):

I uploaded a small patch that changes sim_login from using {{{ my $cmd = "cd $path && $SHELL -l"; }}} to

{{{ my $cmd = "cd $path || echo "could not change to directory $path"; $SHELL -l"; }}}

This makes it fail gracefully when it can't change to the correct directory. I can change it so it attempts to make the directory, but this seems better because I don't think it's right to attempt to make the path if sourcebasedir is wrong.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/383#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6:59 p.m.

Comment (by eschnett):

Ian, do you like this solution?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/383#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

13 Apr 13 Apr

11:40 p.m.

#383: SimFactory 1 does not create source directory on login -------------------------+-------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: review Priority: major | Milestone: ET_2011_05 Component: SimFactory | Version: Resolution: | Keywords: -------------------------+-------------------------------------------------- Changes (by knarf):

* status: new => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/383#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

14 Apr 14 Apr

9:34 a.m.

#383: SimFactory 1 does not create source directory on login -------------------------+-------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: review Priority: major | Milestone: ET_2011_11 Component: SimFactory | Version: Resolution: | Keywords: -------------------------+-------------------------------------------------- Changes (by knarf):

* milestone: ET_2011_05 => ET_2011_11

Comment:

Ian will not have time until the release. I believe it's now fixed, but I will just delay the ticket for after the release for Ian to still have a look and opportunity for input.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/383#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

20 Apr 20 Apr

11:29 a.m.

#383: SimFactory 1 does not create source directory on login -------------------------+-------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: review Priority: major | Milestone: ET_2011_11 Component: SimFactory | Version: Resolution: | Keywords: -------------------------+--------------------------------------------------

Comment (by knarf):

A similar patch has now been appplied to the python version.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/383#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2 May 2 May

6:24 p.m.

#383: SimFactory 1 does not create source directory on login -------------------------+-------------------------------------------------- Reporter: hinder | Owner: mthomas Type: defect | Status: closed Priority: major | Milestone: ET_2011_11 Component: SimFactory | Version: Resolution: fixed | Keywords: -------------------------+-------------------------------------------------- Changes (by eschnett):

* status: review => closed * resolution: => fixed

Comment:

Applied.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/383#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

5640

Age (days ago)

5668

Last active (days ago)

trac@lists.einsteintoolkit.org

11 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit