[Einstein Toolkit] #489: Hydro_InitExcision test cases failing - shift_state = 0 no longer supported
#489: Hydro_InitExcision test cases failing - shift_state = 0 no longer supported -----------------------------------+---------------------------------------- Reporter: hinder | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: Hydro_InitExcision | -----------------------------------+---------------------------------------- All of the Hydro_InitExcision test cases are failing. The error seems to be
WARNING level 0 in thorn GRHydro processor 0 host sl-18.damiana.admin (line 128 of GRHydro_Boundaries.F90): -> shift_state = 0 (no shift storage) no longer supported! [1mWARNING level 0 in thorn GRHydro processor 0 host sl-18.damiana.admin (line 128 of GRHydro_Boundaries.F90): ->[0m shift_state = 0 (no shift storage) no longer supported!
They started failing on 04-08-2011 when this check was added in GRHydro. See attached diff for what changed in the Cactus tree between the test passing and failing.
I don't know the code, but would it make sense to change
ADMBase::initial_shift = "none"
to
ADMBase::initial_shift = "zero"
in the test parameter files?
#489: Hydro_InitExcision test cases failing - shift_state = 0 no longer supported ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: Hydro_InitExcision ------------------------------------+---------------------------------------
Comment (by bmundim):
I don't know the code, but would it make sense to change
ADMBase::initial_shift = "none"
to
ADMBase::initial_shift = "zero"
in the test parameter files?
yes, that's correct! please apply.
#489: Hydro_InitExcision test cases failing - shift_state = 0 no longer supported ------------------------------------+--------------------------------------- Reporter: hinder | Owner: hinder Type: defect | Status: accepted Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: Hydro_InitExcision ------------------------------------+--------------------------------------- Changes (by hinder):
* owner: => hinder * status: new => accepted
#489: Hydro_InitExcision test cases failing - shift_state = 0 no longer supported ------------------------------------+--------------------------------------- Reporter: hinder | Owner: hinder Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: Hydro_InitExcision ------------------------------------+--------------------------------------- Changes (by hinder):
* status: accepted => closed * resolution: => fixed
Comment:
Committed in changeset:118/EinsteinInitialData/Hydro_InitExcision. Tests pass again.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit