#1642: GRHydro should not depend on ADMMacros --------------------+------------------------------------------------------- Reporter: knarf | Owner: Type: defect | Status: new Priority: major | Milestone: ET_2014_11 Component: Other | Version: development version Keywords: | --------------------+------------------------------------------------------- At the moment GRHydro uses ADMMacros::spatial_order to decide about how to calculate the source terms. ADMMacros is deprecated. There should be another mechanism to do this, and the dependence should be removed. Note that even the C++ code uses this parameter.
The simplest solution would probably be a GRHydro parameter, and this is what I suggest (sources_spatial_order).
#1642: GRHydro should not depend on ADMMacros ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: review Priority: major | Milestone: ET_2014_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by knarf):
* status: new => review
#1642: GRHydro should not depend on ADMMacros ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: ET_2014_11 Component: Other | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: review => reviewed_ok
Comment:
As discussed in the phone call today: no objections to making it a GRHydro parameter. It really seems to be only used in Source.F90 to decide which derivative to compute.
#1642: GRHydro should not depend on ADMMacros ---------------------+------------------------------------------------------ Reporter: knarf | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: postrelease ---------------------+------------------------------------------------------ Changes (by knarf):
* keywords: => postrelease * milestone: ET_2014_11 =>
#1642: GRHydro should not depend on ADMMacros ---------------------+------------------------------------------------------ Reporter: knarf | Owner: rhaas Type: defect | Status: assigned Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: postrelease ---------------------+------------------------------------------------------ Changes (by rhaas):
* owner: => rhaas * status: reviewed_ok => assigned
Comment:
There was nothing to review here.
#1642: GRHydro should not depend on ADMMacros ---------------------+------------------------------------------------------ Reporter: knarf | Owner: rhaas Type: defect | Status: review Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: postrelease ---------------------+------------------------------------------------------ Changes (by knarf):
* status: assigned => review
Comment:
https://bitbucket.org/einsteintoolkit/einsteinevolve/pull-request/3 /grhydro-remove-dependency-on-admmacros/diff
Now there is. :)
#1642: GRHydro should not depend on ADMMacros ---------------------+------------------------------------------------------ Reporter: knarf | Owner: rhaas Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: postrelease ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: review => reviewed_ok
Comment:
Patch looks fine. Please apply.
#1642: GRHydro should not depend on ADMMacros ---------------------+------------------------------------------------------ Reporter: knarf | Owner: rhaas Type: defect | Status: closed Priority: major | Milestone: Component: Other | Version: development version Resolution: fixed | Keywords: postrelease ---------------------+------------------------------------------------------ Changes (by knarf):
* status: reviewed_ok => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit