[Einstein Toolkit] #1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90, RotatingSymmetry180, etc.
#1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90, RotatingSymmetry180, etc. ---------------------------------------------------+------------------------ Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: RotatingSymmetry180RotatingSymmetry90 | ---------------------------------------------------+------------------------ I think only the RotatingSymmetry ones need work since Peridic does not need to know what type of object it acts on. See #1236
#1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90, RotatingSymmetry180, etc. ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: RotatingSymmetry180RotatingSymmetry90 ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
I attach in vectors90.patch a patch to support groups of vectors the same way reflectionsymmetry does. The parfile tests this with Luke Robert's thorn. It requires access to Zelmani. Please ignore the no_local_reductions90.patch file as I only uploaded that one accidentally.
Please comment on whether this is an acceptable way of implementing the functionality (or whether we want a separate variable "tensorcomponent" rather than all the "/ tensorlength").
#1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90, RotatingSymmetry180, etc. ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: RotatingSymmetry180RotatingSymmetry90 ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Yes, this is a good way.
#1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90, RotatingSymmetry180, etc. ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: RotatingSymmetry180RotatingSymmetry90 ------------------------------------+---------------------------------------
Comment (by rhaas):
removed leftover printf from patch.
#1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90, RotatingSymmetry180, etc. ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: RotatingSymmetry180RotatingSymmetry90 ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as rev 89 of RotatingSymmetry90.
#1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90, RotatingSymmetry180, etc. ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reopened Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: RotatingSymmetry180RotatingSymmetry90 ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: closed => reopened * resolution: fixed =>
Comment:
A patch for rotatingsymmetry 180 is missing. The implementation for roatingsymmety90 has a bug in the symmetry interpolation code (boundary condition work fine).
#1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90, RotatingSymmetry180, etc. ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: RotatingSymmetry180RotatingSymmetry90 ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reopened => review
Comment:
I added a patch to correct interpolation in rotatingsymmetry90, before it would have failed (triggered an assert) if multiple vector components were interpolated at the same time. There is a very helpful comment in the code just above the assert (interpolate.c lin 886) , many thanks to whoever put the comment there.
#1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90, RotatingSymmetry180, etc. ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: RotatingSymmetry180RotatingSymmetry90 ------------------------------------+--------------------------------------- Changes (by rhaas):
* priority: minor => major
Comment:
bump priority since people are actually hit by this.
#1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90, RotatingSymmetry180, etc. ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: RotatingSymmetry180RotatingSymmetry90 ------------------------------------+---------------------------------------
Comment (by anonymous):
Reviewed ok! Please apply!
#1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90, RotatingSymmetry180, etc. ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: RotatingSymmetry180RotatingSymmetry90 ------------------------------------+---------------------------------------
Comment (by pmoesta@…):
Reviewed ok! Please apply!
#1371: handle vector groups of vectors correctly in Periodic, RotatingSymmetry90, RotatingSymmetry180, etc. ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: RotatingSymmetry180RotatingSymmetry90 ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => reopened
Comment:
applied as rev90 of RotatingSymmetry90. Leaving ticket open to remind someone to implement the same code in RotatingSymmetry180.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit