#1543: hwloc in lib64 -----------------------------------+---------------------------------------- Reporter: barry.wardell | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: | -----------------------------------+---------------------------------------- Often the hwloc libraries are installed in /usr/lib64. However, several places in the configure script assumes it is installed in $HWLOC_DIR/lib. I suggest applying the attached patch to correct this.
Additionally, the script assumes $HWLOC_DIR/lib/libhwloc.la exists. This causes grep to print a confusing error if it does not exist. The second patch causes grep to only run if this file exists.
#1543: hwloc in lib64 ------------------------------------+--------------------------------------- Reporter: barry.wardell | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review
Comment:
Patch 1 is fine.
For patch 2, I suggest redirecting grep's stderr to /dev/null instead: grep -q ... 2>/dev/null.
#1543: hwloc in lib64 ------------------------------------+--------------------------------------- Reporter: barry.wardell | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
#1543: hwloc in lib64 ------------------------------------+--------------------------------------- Reporter: barry.wardell | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by barry.wardell):
Attached is an updated version of the second patch with your suggestion. I don't think I have commit access to hwloc, so I will have to leave it to someone else to commit the patches.
#1543: hwloc in lib64 ------------------------------------+--------------------------------------- Reporter: barry.wardell | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
Barry, please ask for write access to the ET thorns.
#1543: hwloc in lib64 ------------------------------------+--------------------------------------- Reporter: barry.wardell | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by barry.wardell):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as revs 44 and 45 of hwloc
trac@lists.einsteintoolkit.org
-
Einstein Toolkit