[Einstein Toolkit] #1516: using GRHydro::reconstruct_Wv with recon_method = WENO segfaults
#1516: using GRHydro::reconstruct_Wv with recon_method = WENO segfaults -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: GRhydro backport | -----------------------------------+---------------------------------------- revision 587 of GRHydro intoruced a regression and causes the code to abort with a segfault if GRHydro::reconstruct_Wv = yes and GRHydro:recon_method = WENO are both set.
The problem is access to an uninitialized pointer. The attached patch removes the pointers and moves the function call using the pointer inside of a set of if statements which makes the usage of pointer unnecessary.
#1516: using GRHydro::reconstruct_Wv with recon_method = WENO segfaults ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: GRhydro backport ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
#1516: using GRHydro::reconstruct_Wv with recon_method = WENO segfaults ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: GRhydro backport ------------------------------------+--------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
Comment:
reviewed ok, pending some discussed indentation changes.
#1516: using GRHydro::reconstruct_Wv with recon_method = WENO segfaults ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: GRhydro backport ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as rev 596 and 597 of GRHydro.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit