#1852: MoL: Add "RK2-central" scheme -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: | -----------------------------------+---------------------------------------- This is an RK2 integrator where the first substep has size dt/2.
See <https://bitbucket.org/cactuscode/cactusnumerical/pull-requests/6/mol- add-rk2-central-scheme/diff>.
#1852: MoL: Add "RK2-central" scheme ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
Comment:
Fine with me. Only minor comments:
* author should be given as Erik Schnetter in source code * error messages should identify as RK2Central rather than RK2 * please add a test for this integrator to thorn TestMoL * all references to "Ian" in source code should be changed to "Erik"
#1852: MoL: Add "RK2-central" scheme ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => reviewed_ok
#1852: MoL: Add "RK2-central" scheme ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
I addressed Roland's comments, added a test case to TestMoL, and merged the branch.
trac@lists.einsteintoolkit.org