#1456: TerminationTrigger fails if the termination file cannot be created --------------------+------------------------------------------------------- Reporter: hinder | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Cactus | Version: development version Keywords: | --------------------+------------------------------------------------------- In TerminationTrigger file.c, there is this code:
file = fopen (get_termination_file(), "w"); fclose (file);
This leads to a segmentation fault if the file cannot be created, e.g. due to a missing directory in the path (for example if the parameter file has been copied from another cluster and uses an absolute path). I would add an error check here to abort if file == 0, but wanted to check that this was the right thing to do.
#1456: TerminationTrigger fails if the termination file cannot be created ---------------------+------------------------------------------------------ Reporter: hinder | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by eschnett):
Yes, this is correct since the current behaviour (segfault) also aborts, and since the user explicitly requested that a termination file should be created.
#1456: TerminationTrigger fails if the termination file cannot be created ---------------------+------------------------------------------------------ Reporter: hinder | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by knarf):
I agree.
#1456: TerminationTrigger fails if the termination file cannot be created ---------------------+------------------------------------------------------ Reporter: hinder | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by hinder):
* status: new => closed * resolution: => fixed
Comment:
Fixed in r22.
trac@lists.einsteintoolkit.org