#182: Variable-assignment options to "make" gain additional whitespace --------------------+------------------------------------------------------- Reporter: hinder | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Cactus | Version: Keywords: make | --------------------+------------------------------------------------------- If you build a Cactus configuration using
make <configname>-config <option1>=<value1> <option2>=<value2>
the <value1>... get spaces added to them in configs/<configname>/config- info. This does not happen if you use options from a file. Depending on how the variables are used, this extra space at the end can be a problem (e.g. it causes problems with GSL_DIR, as the GSL script doesn't expect whitespace at the end of the variable).
I traced this to a greedy regular expression in setup_configuration.pl. The attached patch fixes the problem, but has not been tested extensively.
#182: Variable-assignment options to "make" gain additional whitespace ---------------------+------------------------------------------------------ Reporter: hinder | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: make ---------------------+------------------------------------------------------
Comment (by eschnett):
Okay to apply.
#182: Variable-assignment options to "make" gain additional whitespace ---------------------+------------------------------------------------------ Reporter: hinder | Owner: hinder Type: defect | Status: assigned Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: make ---------------------+------------------------------------------------------ Changes (by eschnett):
* owner: => hinder * status: new => assigned
Comment:
This patch seems correct. Please apply it.
#182: Variable-assignment options to "make" gain additional whitespace ---------------------+------------------------------------------------------ Reporter: hinder | Owner: hinder Type: defect | Status: closed Priority: minor | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: make ---------------------+------------------------------------------------------ Changes (by hinder):
* status: assigned => closed * resolution: => fixed
Comment:
Patch applied in r4667.
trac@lists.einsteintoolkit.org