[Einstein Toolkit] #1019: GRHydro/MoL/TmunuBase: allow grhydro evolution without Tmunu storage
#1019: GRHydro/MoL/TmunuBase: allow grhydro evolution without Tmunu storage -----------------------------------+---------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: new Priority: critical | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: GRHydro MoL TmunuBase | -----------------------------------+---------------------------------------- Since r350 we can't evolve GRHydro without assigning storage for Tmunu. This is far from ideal, since we may want to study only special relativistic effects or to evolve a non-self-gravitating fluid with a live metric. In both cases we don't need storage for Tmunu.
The attached patches fix this problem. It requires to schedule TmunuBase_SetStressEnergyState at Wragh instead of basegrid and before Mol registers any variables.
#1019: GRHydro/MoL/TmunuBase: allow grhydro evolution without Tmunu storage ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: review Priority: critical | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro MoL TmunuBase ------------------------------------+--------------------------------------- Changes (by bmundim):
* status: new => review
#1019: GRHydro/MoL/TmunuBase: allow grhydro evolution without Tmunu storage ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: review Priority: critical | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro MoL TmunuBase ------------------------------------+---------------------------------------
Comment (by eschnett):
The patch seems harmless enough. However, it touches the schedule, and I am always afraid that this will break something. How well did you test this patch?
#1019: GRHydro/MoL/TmunuBase: allow grhydro evolution without Tmunu storage ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: review Priority: critical | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro MoL TmunuBase ------------------------------------+---------------------------------------
Comment (by bmundim):
I tested with a parameter file that was broken by r350 and it is now fixed after these patches. This parameter file represents a special relativistic MHD test of GRHydro. I am running on my workstation all test suites before and after the patches. I will report on those results here later when they are done.
#1019: GRHydro/MoL/TmunuBase: allow grhydro evolution without Tmunu storage ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: review Priority: critical | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro MoL TmunuBase ------------------------------------+---------------------------------------
Comment (by bmundim):
It doesn't fail any testsuite that it is not already failing. I have attached the test suite results before and after these patches ran at frozenstar, my workstation. Also the MHD par file was run on ranger. Is it ok to apply these patches?
Thanks, Bruno.
#1019: GRHydro/MoL/TmunuBase: allow grhydro evolution without Tmunu storage ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: reviewed_ok Priority: critical | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro MoL TmunuBase ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Please apply.
#1019: GRHydro/MoL/TmunuBase: allow grhydro evolution without Tmunu storage ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: closed Priority: critical | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: GRHydro MoL TmunuBase ------------------------------------+--------------------------------------- Changes (by bmundim):
* status: reviewed_ok => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit