#1187: Cactus allows for negative error level -------------------------+-------------------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: new Priority: minor | Milestone: Component: Cactus | Version: development version Keywords: | -------------------------+-------------------------------------------------- Currently, Cactus allows to set a negative error level through the command line option. This leads to CCTK_WARN(0,"") not necessarily aborting. While this is not wrong by itself, a lot of code assumes an abort at that point.
I propose to change CCTKi_SetErrorLevel() to only accept non-negative error levels and to change the command-parsing code to give an error message for that case as well. Patch is attached.
#1187: Cactus allows for negative error level --------------------------+------------------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):
* status: new => review
#1187: Cactus allows for negative error level --------------------------+------------------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: review => reviewed_ok
Comment:
Looks good. Please apply.
#1187: Cactus allows for negative error level --------------------------+------------------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: closed Priority: minor | Milestone: Component: Cactus | Version: development version Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):
* status: reviewed_ok => closed * resolution: => fixed
trac@lists.einsteintoolkit.org
-
Einstein Toolkit