#821: avoid allocting temp memory twice in EOS Omni -------------------+-------------------------------------------------------- Reporter: rhaas | Type: enhancement Status: new | Priority: minor Milestone: | Component: Other Version: | Keywords: -------------------+-------------------------------------------------------- instead of storing a copy of the data in the Fortran module store Fortran pointers.
#821: avoid allocting temp memory twice in EOS Omni --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Other | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: new => review
#821: avoid allocting temp memory twice in EOS Omni --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Other | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
Patch looks ok, but I a) didn't test it and b) don't know how to work these Fortran pointers (otherwise I wouldn't have written the now removed comments :). If this passes the tests (and is indeed tested), please commit.
#821: avoid allocting temp memory twice in EOS Omni --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Other | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by rhaas):
It passes all existing EOSOmni table reader tests -- of which there are none :-). Seriously though I add ed a tiny function to dump the read in data into an ascii file and the ascii file compares identical before and after the patch. This is not urgent though and we can use to hunt around for a EOS Omni table reader test suite.
#821: avoid allocting temp memory twice in EOS Omni --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Other | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
In this case ok to commit - but I think this is not important enough to go into the next release, so please hold back until after it.
#821: avoid allocting temp memory twice in EOS Omni --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: ET_2012_11 Component: Other | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):
* milestone: => ET_2012_11
#821: avoid allocting temp memory twice in EOS Omni --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: ET_2012_11 Component: Other | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
Comment:
applied as rev 62 of EOS_Omni.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit