#1748: enable C++ code in GRHydro by default -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: unset | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: GRHydro | -----------------------------------+---------------------------------------- the C++ code is significantly faster and hopefully easier to maintain since it gets rid of the duplicated files and instead has only a single set of source files for both MHD and non MHD code.
It actually passes all the test.
The change is in https://bitbucket.org/einsteintoolkit/einsteinevolve /pull-request/7/grhydro-enable-c-code-by-default/diff
#1748: enable C++ code in GRHydro by default ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: unset | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
#1748: enable C++ code in GRHydro by default ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: unset | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
Comment (by knarf):
Please do. It was agreed to be one of the plans for the next release.
#1748: enable C++ code in GRHydro by default ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: unset | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by knarf):
* status: review => reviewed_ok
#1748: enable C++ code in GRHydro by default ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: unset | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Done. C++ code is now the default as of git hash fe5578d1d28d813cee37e35df69572ddc2f0ef71 of einsteinevolve.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit