[Einstein Toolkit] #773: McLachlan dissipation should be disabled by default

List overview All Threads
Download

newer

older

[Einstein Toolkit] #176: Test...

[Einstein Toolkit] #1130: Cactus...

Einstein Toolkit

15 Mar 2012 15 Mar '12

3:28 a.m.

#773: McLachlan dissipation should be disabled by default -------------------------+-------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: Other | Version: Keywords: | -------------------------+-------------------------------------------------- In the current version of McLachlan, the parameter apply_dissipation is set to "always" by default. The corresponding "epsdiss" is set to 0 by default. The dissipation calculation in McLachlan is expensive due to the way that it iterates over variables. Use of the Dissipation thorn or similar is usually much faster. I had not realised that apply_dissipation was "always" by default. I think it should be "never".

OK to change? (with announcement to the mailing list)

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

15 Mar 15 Mar

7:25 a.m.

#773: McLachlan dissipation should be disabled by default --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: Other | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by eschnett):

What about modifying the way in which McLachlan iterates over variables? One calculation per variable should be easy to realise: {{{ dissCalcs = Table[ { Name -> BSSN <> "_Dissipation_" <> ToString[var /. {Tensor[n_,__] -> n}], Schedule -> {"IN " <> BSSN <> "_evolCalcGroup " <> "AFTER (" <> BSSN <> "_RHS1 " <> BSSN <> "_RHS2)"}, ConditionalOnKeyword -> {"apply_dissipation", "always"}, Where -> InteriorNoSync, Shorthands -> {epsdiss[ua]}, Equations -> { epsdiss[ua] -> EpsDiss, dot[var] -> dot[var] + epsdiss[ux] PDdiss[var,lx] } }, {var, {phi, gt[la,lb], Xt[ui], trK, At[la,lb], alpha, A, beta[ua], B[ua]}} ]; }}}

Otherwise, this is okay to change.

Do you then also want to change the default epsdiss value to be the same as for thorn Dissipation?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

5 May 5 May

9:21 a.m.

#773: McLachlan dissipation should be disabled by default --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: Other | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):

* status: new => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:22 a.m.

#773: McLachlan dissipation should be disabled by default --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: Other | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):

* status: review => reviewed_ok

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

7 May 7 May

9:29 p.m.

#773: McLachlan dissipation should be disabled by default --------------------------+------------------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: ET_2012_05 Component: Other | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):

* milestone: => ET_2012_05

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

16 May 16 May

12:51 p.m.

#773: McLachlan dissipation should be disabled by default --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: assigned Priority: major | Milestone: ET_2012_05 Component: Other | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):

* owner: => eschnett * status: reviewed_ok => assigned

Comment:

Erik: would you mind to apply this? Ian is busy and I am not sure what precisely should be applied (ie just the parameter change or also the change in Kranc code).

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

17 May 17 May

5:40 p.m.

Comment (by eschnett):

Only the default value of the parameter should be changed.

I am trying this change (only changing the default for apply_dissipation from "always" to "never"). For some reason, this breaks the test cases {{{ KerrSchild-rotating-180 (from RotatingSymmetry180) KerrSchild-rotating-90 (from RotatingSymmetry90) }}} which don't set any of McLachlan's dissipation parameters, and which should therefore currently not be applying dissipation. The differences look significant.

I don't understand why there are differences in these test cases, and am therefore not applying this patch at the moment.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

21 May 21 May

10:26 a.m.

#773: McLachlan dissipation should be disabled by default --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: assigned Priority: major | Milestone: ET_2012_11 Component: Other | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by knarf):

* milestone: ET_2012_05 => ET_2012_11

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

22 Oct 22 Oct

2:44 p.m.

#773: McLachlan dissipation should be disabled by default --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: closed Priority: major | Milestone: ET_2012_11 Component: Other | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):

* status: assigned => closed * resolution: => fixed

Comment:

The current version of McLachlan already has the dissipation set to zero by default.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3:19 p.m.

#773: McLachlan dissipation should be disabled by default --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: reopened Priority: major | Milestone: ET_2012_11 Component: Other | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):

* status: closed => reopened * resolution: fixed =>

Comment:

This ticket is actually about the keyword apply_dissipation, not about the value of the dissipation parameter. Re-opening.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

23 Oct 23 Oct

10:03 a.m.

#773: McLachlan dissipation should be disabled by default --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: reopened Priority: major | Milestone: ET_2012_11 Component: Other | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by diener):

I have just tried to set the default for apply_dissipation to "never" and I don't see any issues with the test cases mentioned above.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:10 a.m.

#773: McLachlan dissipation should be disabled by default --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: review Priority: major | Milestone: ET_2012_11 Component: Other | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):

* status: reopened => review

Comment:

Good! Maybe it is a weirdness for my machine only.

Could you commit this?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:10 a.m.

#773: McLachlan dissipation should be disabled by default --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: reviewed_ok Priority: major | Milestone: ET_2012_11 Component: Other | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):

* status: review => reviewed_ok

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:12 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:59 a.m.

#773: McLachlan dissipation should be disabled by default --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: closed Priority: major | Milestone: ET_2012_11 Component: Other | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by diener):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

Committed.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/773#comment:13 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

5099

Age (days ago)

5321

Last active (days ago)

trac@lists.einsteintoolkit.org

13 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit