#1172: Remove unnecessary exp/log calls in EOS_Omni -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- EOS_Omni seems to call exp/log more often than necessary in the nuc_eos table lookup routines. Use algebraic identities to remove them.
#1172: Remove unnecessary exp/log calls in EOS_Omni ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by knarf):
Can you please provide specific examples, or maybe even a patch? I fear otherwise this ticket is just going to rot here.
#1172: Remove unnecessary exp/log calls in EOS_Omni ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by anonymous):
Here is one example: {{{ barotropiceos_logrho(:) = log10(10.0d0**barotropiceos_logrho(:) * rho_gf) }}}
This code first exponentiates a quantity, and then takes a logarithm. The code contains many other similar expressions. I believe this code was implemented as a literal translation from a publication, without optimizing its numerics.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit