[Einstein Toolkit] #1840: ExternalLibraris/pthreads does not provide CCTK_PTHREADS define

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1838:...

[Einstein Toolkit] #1867:...

Einstein Toolkit

10 Nov 2015 10 Nov '15

6:06 p.m.

#1840: ExternalLibraris/pthreads does not provide CCTK_PTHREADS define -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: rhaas Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: pthreads | -----------------------------------+---------------------------------------- This means it is not a drop in replacement for the old mechanism and eg HTTPD complains at runtime with: {{{ WARNING level 1 from host comet-ln3.sdsc.edu process 0 while executing schedule bin HTTP_Startup, routine HTTPD::HTTP_StartServer in thorn HTTPD, file /home/rhaas/cactus/ET_trunk/arrangements/CactusConnect/HTTPD/src/Startup.c:97: -> Parameter 'HTTPD::use_pthreads' is set to "yes" but you didn't configure with PTHREADS. Setting will be ignored. }}}

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1840 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

10 Nov 10 Nov

6:09 p.m.

#1840: ExternalLibraris/pthreads does not provide CCTK_PTHREADS define ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: rhaas Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: pthreads ------------------------------------+---------------------------------------

Comment (by rhaas):

pthreads itself seems to still provide the define, yet the define is not visible to httpd since the thorn does not required the PTHREADS capability.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1840#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11 Nov 11 Nov

4:14 p.m.

Comment (by bmundim):

The same issue happens for Watchdog. I have just required pthreads there as a solution:

{{{ https://bitbucket.org/cactuscode/cactusutils/pull-requests/5/watchdog-add- requirement-for-pthreads/diff }}}

Shouldn't this work here as well?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1840#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

4:19 p.m.

Comment (by rhaas):

Add the requirement (optional in the case of HTTPD) works, but that still does not make ExternalLibraries/pthreads a drop in replacement for the old PTHREADS setting since one has to do more than just change the option list and config options, one has to also change the client thorn.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1840#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

5:25 p.m.

Comment (by knarf):

That is still ok for me. Roland: can you please test the patch for HTTPD, and if it works (requiring optionally pthreads) push both to master and ET_2015_11 ?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1840#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9 Mar 9 Mar

1:43 p.m.

Comment (by dradice@…):

Could you please also merge the patch for WatchDog into ET_2015_11?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1840#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:45 p.m.

Comment (by eschnett):

There shouldn't be any define with this name; this is now called {{{CCTK_CAPABILITY_PTHREADS}}}, and is set automatically. The old name exists only for backward compatibility.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1840#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:58 p.m.

Comment (by dradice@…):

As it is now, WatchDog will not even compile. Cherry-picking 9fc3e3d from master into ET_2015_11 would fix it.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1840#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10 Mar 10 Mar

3:31 a.m.

Comment (by rhaas):

...

The old name exists only for backward compatibility.

That is true. Yet the change required is small and we usually want ExternalLibraries to be as close to a drop in replacement to the old "external" interface as possible. This is the reason MPI for example provides such a define. So in order to keep backwards compatibility I would include the define.

New ExternalLibraries won't do this of course, only ones that replace existing facilities.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1840#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

3:34 a.m.

Comment (by rhaas):

Replying to [comment:7 dradice@…]:

...

As it is now, WatchDog will not even compile. Cherry-picking 9fc3e3d

from master into ET_2015_11 would fix it.

If WatchDog fails to compile, this is a bug and should be backported if possible. Though: which repository is 9fc3e3d in?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1840#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:49 a.m.

Comment (by dradice@…):

Sorry, I was not very clear before. I was asking to merge the patch that Bruno Mundim made for the WatchDog thorn also to the release branch of CactusUtils. It has been merged only into master. If I am not mistaken its hash should be 9fc3e3d. Also, apologies if this is not the right ticket, but I haven't found any other discussion related to that merge request on the bug tracker.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1840#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1 Apr 1 Apr

6:51 a.m.

#1840: ExternalLibraris/pthreads does not provide CCTK_PTHREADS define ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: rhaas Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: pthreads ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: new => closed * resolution: => fixed

Comment:

I backported 9fc3e3d onto ET_2015_11_v0 of cactusutils in git hash 87fbb7a. I added the OPTIONAL dependency on pthreads to HTTPD in git hash 06887ce of cactusconnect and made HTTPD look for HAVE_CAPABILITY_PTHREADS in ed05d31.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1840#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

3843

Age (days ago)

3985

Last active (days ago)

trac@lists.einsteintoolkit.org

11 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit