#1677: Support attribute((nonnull)), attribute((returns_nonnull)) -------------------------+-------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: Other | Version: development version Keywords: | -------------------------+-------------------------------------------------- GCC (and probably other compilers) have attributes nonnull and returns_nonnull. These describe functions that require either arguments or return values to be not null, allowing both additional optimizations and consistency checks.
I would like to add support for Cactus's autoconf mechanism to detect this, and then use these attributes in a few central places such as CCTK_ARGUMENTS or CCTK_PARAMETERS.
#1677: Support attribute((nonnull)), attribute((returns_nonnull)) --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: Other | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: new => review
#1677: Support attribute((nonnull)), attribute((returns_nonnull)) --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* component: Other => Cactus
#1677: Support attribute((nonnull)), attribute((returns_nonnull)) --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by knarf):
I don't see a reason against it, but there is nothing to review right now.
#1677: Support attribute((nonnull)), attribute((returns_nonnull)) --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
Pull request is at <https://bitbucket.org/cactuscode/cactus/pull-request/1 /support-attribute-nonnull>.
#1677: Support attribute((nonnull)), attribute((returns_nonnull)) --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: Cactus | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Approved during telecon.
#1677: Support attribute((nonnull)), attribute((returns_nonnull)) --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: major | Milestone: Component: Cactus | Version: development version Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied via commit 9710f86.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit