[Einstein Toolkit] #1557: include thorn TestMoL in ET

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1564:...

[Einstein Toolkit] #1561: Show...

Einstein Toolkit

13 Mar 2014 13 Mar '14

6:24 p.m.

#1557: include thorn TestMoL in ET -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: MoL | -----------------------------------+---------------------------------------- the thorn TestMoL (for the CactusTest arrangment) exercises most of MoL's integrators (not the Adams-Bashforth ones yet nor the generic one since they are "different").

It would be useful to include in the ET to have a basic test of the central ODE solver.

The thorn is currently in incoming {{{ svn co https://svn.einsteintoolkit.org/incoming/TestMoL }}}

it contains test cases (that's the whole point) and some documentation. I have used it to test the recent MoL commits and found two outstanding bugs that way.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1557 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

13 Mar 13 Mar

6:24 p.m.

#1557: include thorn TestMoL in ET ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: MoL ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: new => review

Comment:

Ok to include in the ET thorn list?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1557#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8:09 p.m.

Comment (by eschnett):

This thorn looks good.

Typo: file src/Register.c: "chaning".

cctk_Functions.h is only necessary in Fortran (where it declares a macro DECLARE_CCTK_FUNCTIONS); it is not necessary in C/C++ (since this macro is not needed).

cctk_Loop.h is automatically included from cctk.h.

The return codes in Register.c are not checked?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1557#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

14 Mar 14 Mar

10:55 a.m.

Comment (by rhaas):

* Fixed typos in Register.c * removed unnecessary includes * removed cctk_Functions.h. It is automatically included by cctk_core.h and provides the aliased function prototypes. Is there a reason why this not also done for Fortran? * added assert's on the return values. They will never trigger since MoL itself contains level 0 warnings whenever it would not return 0 (this is documented in MoL's documentation.tex).

Frank: would you mind creating a repository for the thorn in CactusTests? Alternatively, we can wait until the gid transition and add it at that point.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1557#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

15 Mar 15 Mar

9:20 p.m.

#1557: include thorn TestMoL in ET ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: MoL ------------------------------------+--------------------------------------- Changes (by eschnett):

* status: review => reviewed_ok

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1557#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

17 Mar 17 Mar

5:21 a.m.

#1557: include thorn TestMoL in ET ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: MoL ------------------------------------+---------------------------------------

Comment (by hinder):

Please let Barry and me know when the repository has been moved to svn.cactuscode.org so that we can create the git mirror and add it to the EinsteinToolkit git super-repository, *before* it is added to the thornlist. Otherwise, when it is added to the thornlist, the build and test will start to fail, as the thorn will not be present. We would automate this, but with the impending move to Git, we didn't think it was worthwhile.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1557#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12:59 p.m.

#1557: include thorn TestMoL in ET ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: MoL ------------------------------------+---------------------------------------

Comment (by knarf):

https://svn.cactuscode.org/arrangements/CactusTest/TestMoL/

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1557#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:55 p.m.

#1557: include thorn TestMoL in ET ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: MoL ------------------------------------+---------------------------------------

Comment (by rhaas):

Added the current code for TestMoL to the repository. Ian, Barry: if you were to add it to the git super-repo and to the thornlist then we can close the ticket.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1557#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2:17 p.m.

#1557: include thorn TestMoL in ET ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: MoL ------------------------------------+---------------------------------------

Comment (by barry.wardell):

I have created the git mirror and added it to the super-repo. I don't currently have commit access to the ET manifest repository, so could someone either give me commit access or add TestMoL to the thornlist themselves?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1557#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2:46 p.m.

#1557: include thorn TestMoL in ET ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: MoL ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

Thank you Barry.

I added TestMoL to the manifest.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1557#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

4589

Age (days ago)

4593

Last active (days ago)

trac@lists.einsteintoolkit.org

9 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit