[Einstein Toolkit] #1646: McLachlan does not give a reference for the gauge evolution equations
#1646: McLachlan does not give a reference for the gauge evolution equations -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: McLachlan | -----------------------------------+---------------------------------------- McLachlan_BSSN.m does not seem to contain any information (eg in evolCalc) that would tell me from which paper the different expressions for the shift and lapse evolution expression are taken from (which may be useful to understand what the different coefficients mean, since parsing the multiple factors of the type XXXFactor * AAA + (1-XXXFactor) * BBB to get either AAA or BBB is confusing).
#1646: McLachlan does not give a reference for the gauge evolution equations ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: confirmed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: McLachlan ------------------------------------+--------------------------------------- Changes (by hinder):
* status: new => confirmed
Comment:
I believe this is addressed in the rewrite branch. We have not yet switched to the rewrite branch, so I am leaving this ticket open just in case. We should also make sure that the references stay up-to-date (e.g. if the equations are changed, this should be noted in the comment).
#1646: McLachlan does not give a reference for the gauge evolution equations ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: confirmed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: McLachlan ------------------------------------+---------------------------------------
Comment (by rhaas):
No references for the gauge evolution are given in the rewrite code (as of git hash 387e14a) where the relevant Kranc code still reads: {{{
dotalpha -> - (harmonicF alpha^harmonicN IfA[A, + trK - IfCCZ4[2 Theta, 0] + alphaDriver (alpha - 1)]), dot[alpha] -> (+ dotalpha + IfThen[advectLapse!=0, Upwind[beta[ua], alpha, la], 0] + Dissipation[alpha]),
... (* TODO: add not only advection terms, but full Lie derivatives! *) dot[beta[ua]] -> (+ dotbeta[ua] + IfThen[advectShift!=0, Upwind[beta[ub], beta[ua], lb], 0] + Dissipation[beta[ua]]),
dot[B[ua]] -> IfB[+ dotXt[ua] + IfThen[fixAdvectionTerms!=0, Upwind[beta[ub], Xt[ua], lb], 0] - (betaDriverValue (+ B[ua] + IfThen[fixAdvectionTerms!=0 && advectShift!=0, Upwind[beta[ub], beta[ua], lb] / (shiftGammaCoeffValue alpha^shiftAlphaPower), 0])) + IfThen[fixAdvectionTerms==0 && advectShift!=0, Upwind[beta[ub], B[ua], lb], 0] + Dissipation[B[ua]], 0],
}}} ie not reference is given at all.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit