[Einstein Toolkit] #1827: ML_BSSN::LapseACoeff and ML_BSSN::ShiftBCoeff Removed without Proper Deprecation
#1827: ML_BSSN::LapseACoeff and ML_BSSN::ShiftBCoeff Removed without Proper Deprecation --------------------------+------------------------------------------------- Reporter: Zach Etienne | Owner: Type: defect | Status: new Priority: unset | Milestone: ET_2015_11 Component: Other | Version: development version Keywords: | --------------------------+------------------------------------------------- After pulling the latest ET, it appears that practically all of my parameter files no longer work. The reason is simple:
ML_BSSN::LapseACoeff and ML_BSSN::ShiftBCoeff were removed in the McLachlan rewrite and not properly deprecated like all other renamed parameters.
I found this because it broke the IllinoisGRMHD test suite. I am surprised and worried by my finding, because it appears that no other test suite parameter files set these ML_BSSN gauge parameters, so this was not caught earlier.
Perhaps to prevent this from happening in the future, perhaps in some subset of our tests we should manually set *all* parameters in the test parfiles to their defaults. This way any bug in renaming parameters will be caught immediately.
#1827: ML_BSSN::LapseACoeff and ML_BSSN::ShiftBCoeff Removed without Proper Deprecation ---------------------------+------------------------------------------------ Reporter: Zach Etienne | Owner: Type: defect | Status: new Priority: unset | Milestone: ET_2015_11 Component: Other | Version: development version Resolution: | Keywords: McLachlan ---------------------------+------------------------------------------------ Changes (by Zach Etienne):
* keywords: => McLachlan
#1827: ML_BSSN::LapseACoeff and ML_BSSN::ShiftBCoeff Removed without Proper Deprecation ---------------------------+------------------------------------------------ Reporter: Zach Etienne | Owner: Type: defect | Status: new Priority: unset | Milestone: ET_2015_11 Component: Other | Version: development version Resolution: | Keywords: McLachlan ---------------------------+------------------------------------------------
Comment (by Zach Etienne):
Perhaps to prevent this from happening in the future, perhaps in some
subset of our tests we should manually set *all* parameters in the test parfiles to their defaults. This way any bug in renaming parameters will be caught immediately.
I should say, *all*, *otherwise unset* parameters should be manually set to their defaults. This *should* have no impact on the tests, and in addition to catching renamed parameters, it will also, in some cases, catch when parameters are changed from their defaults.
#1827: ML_BSSN::LapseACoeff and ML_BSSN::ShiftBCoeff Removed without Proper Deprecation ---------------------------+------------------------------------------------ Reporter: Zach Etienne | Owner: eschnett Type: defect | Status: assigned Priority: unset | Milestone: ET_2015_11 Component: Other | Version: development version Resolution: | Keywords: McLachlan ---------------------------+------------------------------------------------ Changes (by eschnett):
* owner: => eschnett * status: new => assigned
#1827: ML_BSSN::LapseACoeff and ML_BSSN::ShiftBCoeff Removed without Proper Deprecation ---------------------------+------------------------------------------------ Reporter: Zach Etienne | Owner: eschnett Type: defect | Status: assigned Priority: unset | Milestone: ET_2015_11 Component: Other | Version: development version Resolution: | Keywords: McLachlan ---------------------------+------------------------------------------------
Comment (by eschnett):
This should now be corrected in McLachlan. Please test.
#1827: ML_BSSN::LapseACoeff and ML_BSSN::ShiftBCoeff Removed without Proper Deprecation ---------------------------+------------------------------------------------ Reporter: Zach Etienne | Owner: eschnett Type: defect | Status: review Priority: unset | Milestone: ET_2015_11 Component: Other | Version: development version Resolution: | Keywords: McLachlan ---------------------------+------------------------------------------------ Changes (by knarf):
* status: assigned => review
#1827: ML_BSSN::LapseACoeff and ML_BSSN::ShiftBCoeff Removed without Proper Deprecation ---------------------------+------------------------------------------------ Reporter: Zach Etienne | Owner: eschnett Type: defect | Status: review Priority: unset | Milestone: ET_2015_11 Component: Other | Version: development version Resolution: | Keywords: McLachlan ---------------------------+------------------------------------------------
Comment (by hinder):
Zach, does this work for you now?
#1827: ML_BSSN::LapseACoeff and ML_BSSN::ShiftBCoeff Removed without Proper Deprecation ---------------------------+------------------------------------------------ Reporter: Zach Etienne | Owner: eschnett Type: defect | Status: closed Priority: unset | Milestone: ET_2015_11 Component: Other | Version: development version Resolution: fixed | Keywords: McLachlan ---------------------------+------------------------------------------------ Changes (by hinder):
* status: review => closed * resolution: => fixed
Comment:
No, it didn't work. evolveA was not steerable, so the compatibility code in ML_BSSN_Helper was not able to steer it. I have fixed McLachlan and pushed the fix. The current WVUThorns test passes when these two parameters are put back to their old names.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit