[Einstein Toolkit] #1311: SetMask_SphericalSurface sets mask incorrectly for multiple spheres
#1311: SetMask_SphericalSurface sets mask incorrectly for multiple spheres ----------------------------------------+----------------------------------- Reporter: reisswig@… | Owner: Type: defect | Status: new Priority: blocker | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Keywords: SetMask_SphericalSurface | ----------------------------------------+----------------------------------- SetMask_SphericalSurface loops over all spheres and sets points to "excised" within the sphere radius, and to "not excised" outside. Unfortunately, it clears the mask for each sphere individually, thus overwriting "excised" points from a previous sphere!
The attached patch fixes this by first clearing the mask everywhere before looping over spheres, and then setting points to "excised" if inside a given sphere.
#1311: SetMask_SphericalSurface sets mask incorrectly for multiple spheres -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: defect | Status: review Priority: blocker | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: SetMask_SphericalSurface -----------------------------------------+---------------------------------- Changes (by knarf):
* status: new => review
Comment:
Thanks
#1311: SetMask_SphericalSurface sets mask incorrectly for multiple spheres -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: defect | Status: reviewed_ok Priority: blocker | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: SetMask_SphericalSurface -----------------------------------------+---------------------------------- Changes (by knarf):
* status: review => reviewed_ok
#1311: SetMask_SphericalSurface sets mask incorrectly for multiple spheres -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: defect | Status: reviewed_ok Priority: blocker | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: SetMask_SphericalSurface -----------------------------------------+----------------------------------
Comment (by knarf):
Please apply
#1311: SetMask_SphericalSurface sets mask incorrectly for multiple spheres -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: defect | Status: reviewed_ok Priority: blocker | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: SetMask_SphericalSurface -----------------------------------------+---------------------------------- Changes (by knarf):
* cc: knarf@… (removed) * cc: reisswig@… (added)
#1311: SetMask_SphericalSurface sets mask incorrectly for multiple spheres -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: defect | Status: closed Priority: blocker | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: SetMask_SphericalSurface -----------------------------------------+---------------------------------- Changes (by knarf):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
This has already been applied in r118 a while back.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit