[Einstein Toolkit] #1570: QuasiLocalMeasures qlm_killing_normalise.F90 contains commented out code with no comment
#1570: QuasiLocalMeasures qlm_killing_normalise.F90 contains commented out code with no comment -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: QuasiLocalMeasures | -----------------------------------+---------------------------------------- qlm_killing_normalise in qlm_killing_normalise.F90 triggers an unused variable warning for iii. Looking at the file, the code that would use the variable is inside of an {{{#if 0}}} but there is no indication (neither in the commit message nor in the code) what the difference between the if and the else branch is.
I'd like to either replace the if0 by an if USE_THIS_MEHTOD (and use the same preprocessor constant for the variable declaration) or (even better) remove the whole if0 branch.
#1570: QuasiLocalMeasures qlm_killing_normalise.F90 contains commented out code with no comment ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: QuasiLocalMeasures ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
#1570: QuasiLocalMeasures qlm_killing_normalise.F90 contains commented out code with no comment ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: QuasiLocalMeasures ------------------------------------+---------------------------------------
Comment (by knarf):
This has been in the file since the start (of this repository). I think it is fine to remove the whole section. Please apply, unless Erik has objections (being the author).
#1570: QuasiLocalMeasures qlm_killing_normalise.F90 contains commented out code with no comment ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: optional | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: QuasiLocalMeasures ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
Comment:
Applied as rev 47 of QuasiLocalMeasures.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit