#1142: checkpoint_ID overwrites checkpoint files after each recovery ----------------------+----------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: defect | Status: new Priority: critical | Milestone: Component: Carpet | Version: Keywords: | ----------------------+----------------------------------------------------- Apparently, the parameter checkpoint_ID overwrites checkpoint files after each recovery, i.e. overwrites the checkpoint file from one which just recovered, potentially damaging this checkpoint file irreversibly e.g. if variables changed in post_recover_variables.
Simfactory's default parameter settings and examples should be changed back to separating restarts from each other, so that this kind of problem is avoided.
#1142: checkpoint_ID overwrites checkpoint files after each recovery -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: defect | Status: review Priority: critical | Milestone: Component: Carpet | Version: Resolution: | Keywords: -----------------------+---------------------------------------------------- Changes (by eschnett):
* status: new => review
Comment:
The attached patch executes the schedule bin CPINITIAL only after initial data setup, not after recovering.
#1142: checkpoint_ID overwrites checkpoint files after each recovery -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: defect | Status: review Priority: critical | Milestone: Component: Carpet | Version: Resolution: | Keywords: -----------------------+----------------------------------------------------
Comment (by knarf):
Shouldn't the function declaration of CallAnalysis contain a 'const' for did_recover (the function definition does)? Otherwise please apply.
#1142: checkpoint_ID overwrites checkpoint files after each recovery -----------------------+---------------------------------------------------- Reporter: eschnett | Owner: eschnett Type: defect | Status: closed Priority: critical | Milestone: Component: Carpet | Version: Resolution: fixed | Keywords: -----------------------+---------------------------------------------------- Changes (by eschnett):
* status: review => closed * resolution: => fixed
Comment:
No, const applies only to the local variable, hence it doesn't affect the API.
Applied.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit