#671: ML_ADMConstraints is incorrect -----------------------------------+---------------------------------------- Reporter: hinder | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: ML_ADMConstraints | -----------------------------------+---------------------------------------- ML_ADMConstraints does not compute the constraints correctly. There are errors in the computation of the Ricci tensor. The attached patch corrects these errors. OK to apply?
#671: ML_ADMConstraints is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ML_ADMConstraints ------------------------------------+--------------------------------------- Changes (by hinder):
* status: new => review
#671: ML_ADMConstraints is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ML_ADMConstraints ------------------------------------+---------------------------------------
Comment (by eschnett):
Please apply.
In the BSSN equations, we improved the speed by introducing more local variables for some of the temporaries, instead of have many loops (bound indices) in the equations.
#671: ML_ADMConstraints is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ML_ADMConstraints ------------------------------------+--------------------------------------- Changes (by hinder):
* status: review => closed * resolution: => fixed
Comment:
Committed in 5fd1f73f9ca35f0852c0cb61f77abc8b053f5aff and b3a25f307c9bb55370380b97e6074df1a30f645d.
#671: ML_ADMConstraints is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ML_ADMConstraints ------------------------------------+---------------------------------------
Comment (by hinder):
I have also committed a fix to McLachlan_ADM where the error was repeated (probably it was copied from there originally). Do we need the constraints computed in both places?
#671: ML_ADMConstraints is incorrect ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ML_ADMConstraints ------------------------------------+---------------------------------------
Comment (by eschnett):
I think ML_ADM does not need to compute the constraints.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit