#1771: Improve performance of CarpetInterp2 interpolation -------------------------+-------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: new Priority: minor | Milestone: Component: Carpet | Version: development version Keywords: | -------------------------+-------------------------------------------------- The branch https://bitbucket.org/eschnett/carpet/branch/ianhinder/fasterp_opt#diff contains an optimisation to the CarpetInterp2 interpolation routine which improved the performance of Llama interpatch interpolation in my test by a factor of 5. I did this a while ago, and haven't looked at it recently. Before merging, the following should be done: 1. Check that is applies cleanly to the current version of Carpet 2. Decide whether the vectorisation pragmas need to be protected by Cactus preprocessor guards Or any other changes which people think might be necessary. This should wait until after the upcoming (May 2015) release of the ET.
#1771: Improve performance of CarpetInterp2 interpolation --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: confirmed Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by hinder):
* status: new => confirmed
#1771: Improve performance of CarpetInterp2 interpolation --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: confirmed Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by hinder):
This optimisation applies cleanly to the release, but not to master, due to the code reformat. Erik, would you mind making a version of this patch that applies to master?
#1771: Improve performance of CarpetInterp2 interpolation --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: confirmed Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
Converting a patch is not possible. Instead, I will need to convert the whole file both before and after applying the patch. Has this patch been applied? Do you have a branch name / commit id / commit message?
#1771: Improve performance of CarpetInterp2 interpolation --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: confirmed Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by hinder):
It's in the original ticket description: https://bitbucket.org/eschnett/carpet/branch/ianhinder/fasterp_opt. The branch name is "fasterp_opt". Thanks!
#1771: Improve performance of CarpetInterp2 interpolation --------------------------+------------------------------------------------- Reporter: hinder | Owner: eschnett Type: enhancement | Status: closed Priority: minor | Milestone: Component: Carpet | Version: development version Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: confirmed => closed * resolution: => fixed
Comment:
The code in that branch was applied to Carpet in 2c896aecd8f7bc973c282ea80c42dc21de5e9c65 "CarpetInterp2: Vectorize interpolation" in 2016-04-27.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit