#540: Change case in internal auto-generated file -------------------------+-------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: optional | Milestone: Component: Cactus | Version: Keywords: | -------------------------+-------------------------------------------------- Cactus auto-generates header files from CCL files into the bindings/include directory. One of these files is called ${thorn}_arguments.h, which stands out because "a" is lower case. Other auto-generated files are called e.g. ${thorn}_Schedule.h with an upper case "S". I suggest to change "arguments" to upper case "Arguments".
#540: Change case in internal auto-generated file --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: new => review
#540: Change case in internal auto-generated file --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by hinder):
What happens if a user updates the flesh and tries to build an existing checkout? Will the build fail because it is looking for a file which does not exist? (This might work on Mac OS where the filesystem is case- insensitive.) I think there is a way to force all configurations to be rebuilt - should we use this?
#540: Change case in internal auto-generated file --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
The new file names are only used after code is re-generated. After updating, the flesh continues to use the old files. (This can also be seen from the fact that only perl code is changed, no C files.)
#540: Change case in internal auto-generated file --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: optional | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by hinder):
So the files are all re-generated when the CST runs anyway, so they are either all lowercase or all uppercase.
In that case, please apply!
#540: Change case in internal auto-generated file --------------------------+------------------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: optional | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):
* status: review => closed * resolution: => fixed
Comment:
Committed.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit