#1730: Test failure in GRHydro's balsara4_1d ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------

Comment (by rhaas):

This is most likely a tolerance issue. Balsara4 uses a very high Lorentz factor and we already had to increase the tolerance for the 2d version of the test to 1e-8 for Bcom in 4c0d195. The relevant part of test.ccl would be:

{{{ TEST balsara4_1d { NPROCS 2 RELTOL 1e-8 grhydro::bcom RELTOL 1e-9 hydrobase::w_lorentz RELTOL 1e-10 hydrobase::(eps|rho) } }}}

Which machine/compiler/options did you use to see the test failure?

#1730: Test failure in GRHydro's balsara4_1d ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------

Comment (by rhaas):

Hmm. This is new then. I use gfortran 4.9.2 on my (Debian) workstation and the test passes there (kind of unsurprising since the data was generated on that machine) and I also tested it on a Ubuntu VM shortly after the release. I'll check once more if it still passes or fails and if it fails, when it started to fail.

#1730: Test failure in GRHydro's balsara4_1d ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------

Comment (by rhaas):

Correction, I use gcc 4.9.1.

#1730: Test failure in GRHydro's balsara4_1d ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------

Comment (by eschnett):

I see this error report: {{{ grhydro-divb.x.asc: differences below tolerance on 10 lines hydrobase-bvec.x.asc: differences below tolerance on 2 lines hydrobase-eps.x.asc: differences below tolerance on 30 lines hydrobase-press.x.asc: differences below tolerance on 30 lines hydrobase-rho.x.asc: substantial differences significant differences on 28 (out of 30) lines maximum absolute difference in column 13 is 1.15789600130256e-11 maximum relative difference in column 13 is 1.1578960013032e-11 (insignificant differences on 2 lines) hydrobase-vel.x.asc: differences below tolerance on 30 lines hydrobase-w_lorentz.x.asc: substantial differences significant differences on 28 (out of 30) lines maximum absolute difference in column 13 is 2.58999932611914e-10 maximum relative difference in column 13 is 1.15799330402901e-11 (insignificant differences on 2 lines) }}}

Yes, I think these tolerances would avoid this error.