#868: Write Formaline tarballs in the background -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- Write the Formaline tarballs in the background (using fork()) to elminiate the wait.
#868: Write Formaline tarballs in the background ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review
#868: Write Formaline tarballs in the background ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
The patch looks ok with maybe the single exception that it does a VInfo from within the fork()ed child which may (or may not) involve transporting stdout data to the MPI root process? The suggested method of using a pthread might be safer in case there are still MPI implementations out there that do not like fork(). Maybe one could add a parameter to disable parallel writing. Otherwise fine to apply.
#868: Write Formaline tarballs in the background ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
I will apply this after the release, possibly using pthreads instead of fork.
#868: Write Formaline tarballs in the background ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
#868: Write Formaline tarballs in the background ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by rhaas):
I'll link to #914 so that we don't forget.
#868: Write Formaline tarballs in the background ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: reviewed_ok => reopened
Comment:
I retract this patch, since using fork() with MPI is in general not safe. An implementation on pthreads should be safe, however.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit